[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#605083: marked as done (linux-2.6: MacBookAir3,* support: USB fixes)

Your message dated Sat, 12 Mar 2011 22:49:21 +0000
with message-id <1299970161.4146.137.camel@localhost>
and subject line Re: Bug#605083: linux-2.6: MacBookAir3,* support: USB fixes
has caused the Debian Bug report #605083,
regarding linux-2.6: MacBookAir3,* support: USB fixes
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
605083: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605083
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-2.6
Severity: wishlist

Hi,

Following the previous set of patches, attached is another patch needed
for proper support of the new MacBook Air machines.

USB seems troublesome and doesn't work properly without this patch.

Thanks,

JB.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=fr_FR@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Tested on MacBookAir3,1.  Without this, we get EPROTO errors when
fetching device config descriptors.

Signed-off-by: Brian Tarricone <brian@tarricone.org>
Reported-by: Benoit Gschwind <gschwind@gnu-log.net>
Tested-by: Edgar Hucek <gimli@dark-green.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>
---
 drivers/usb/host/ehci-pci.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index a1e8d27..8d24d1c 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -148,6 +148,18 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
 			if (pdev->revision < 0xa4)
 				ehci->no_selective_suspend = 1;
 			break;
+
+		/* MCP89 chips on the MacBookAir3,1 give EPROTO when
+		 * fetching device descriptors unless LPM is disabled.
+		 * There are also intermittent problems enumerating
+		 * devices with PPCD enabled.
+		 */
+		case 0x0d9d:
+			ehci_info(ehci, "disable lpm/ppcd for nvidia mcp89");
+			ehci->has_lpm = 0;
+			ehci->has_ppcd = 0;
+			ehci->command &= ~CMD_PPCEE;
+			break;
 		}
 		break;
 	case PCI_VENDOR_ID_VIA:
-- 
1.7.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--- End Message ---
--- Begin Message --- 
Version: 2.6.37~rc5-1~experimental.1

On Sat, 2010-11-27 at 20:02 +0000, Ben Hutchings wrote:
> On Sat, 2010-11-27 at 10:31 +0100, Julien BLACHE wrote:
> > Package: linux-2.6
> > Severity: wishlist
> > 
> > Hi,
> > 
> > Following the previous set of patches, attached is another patch needed
> > for proper support of the new MacBook Air machines.
> > 
> > USB seems troublesome and doesn't work properly without this patch.
> 
> This is not yet accepted upstream.  Please ping this bug when it is,
> giving the commit hash as a reference if possible.

Fixed upstream in 2.6.37-rc5 by:

commit a85b4e7f4481c5a1ca89fa63c9c871151965075e
Author: Brian J. Tarricone <brian@tarricone.org>
Date:   Sun Nov 21 21:15:52 2010 -0800

    USB: ehci: disable LPM and PPCD for nVidia MCP89 chips
    
I'll look at backporting this to squeeze as well.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: