Bug#575207: [PATCH] V4L/DVB: budget: Oops: "BUG: unable to handle kernel NULL pointer dereference"
Hi,
Bjørn Mork wrote:
> Never call dvb_frontend_detach if we failed to attach a frontend. This fixes
> the following oops, which will be triggered by a missing stv090x module:
>
> [ 8.172997] DVB: registering new adapter (TT-Budget S2-1600 PCI)
> [ 8.209018] adapter has MAC addr = 00:d0:5c:cc:a7:29
> [ 8.328665] Intel ICH 0000:00:1f.5: PCI INT B -> GSI 17 (level, low) -> IRQ 17
> [ 8.328753] Intel ICH 0000:00:1f.5: setting latency timer to 64
> [ 8.562047] DVB: Unable to find symbol stv090x_attach()
> [ 8.562117] BUG: unable to handle kernel NULL pointer dereference at 000000ac
> [ 8.562239] IP: [<e08b04a3>] dvb_frontend_detach+0x4/0x67 [dvb_core]
> ...
>
> Ref http://bugs.debian.org/575207
>
>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> Cc: stable@kernel.org
> Cc: 575207@bugs.debian.org
> ---
> This patch should apply cleanly to 2.6.32, 2.6.33, 2.6.34-rc2 and with an
> offset to git://linuxtv.org/v4l-dvb.git
>
> Please apply to all of them
>
>
> drivers/media/dvb/ttpci/budget.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb/ttpci/budget.c b/drivers/media/dvb/ttpci/budget.c
> index e48380c..95a463c 100644
> --- a/drivers/media/dvb/ttpci/budget.c
> +++ b/drivers/media/dvb/ttpci/budget.c
> @@ -643,9 +643,6 @@ static void frontend_init(struct budget *budget)
> &budget->i2c_adap,
> &tt1600_isl6423_config);
>
> - } else {
> - dvb_frontend_detach(budget->dvb_frontend);
> - budget->dvb_frontend = NULL;
> }
> }
> break;
This patch fixes only one of three possible problems.
Could you please extend your patch in a way
that it will also catch, if
- dvb_attach(stv6110x_attach,...)
- dvb_attach(isl6423_attach,...)
fail?
CU
Oliver
--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
Reply to: