[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#585419: marked as done (drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions)

Your message dated Tue, 28 Dec 2010 22:24:56 +0100
with message-id <20101228212456.GB14504@stro.at>
and subject line Re: Bug#585419: drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions
has caused the Debian Bug report #585419,
regarding drop vol_id related code from get_fstype in /usr/share/initramfs-tools/scripts/functions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
585419: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585419
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.96.1
Severity: wishlist
Tags: patch


Hi.

May I suggest to drop the code from get_fstype in /usr/share/initramfs-tools/scripts/functions
that uses vol_id.

AFAIK vol_id is no longer available in udev or any other Debian package,
so this is dead code.

Attached is a patch for this.


Cheers,
Chris.

--- /usr/share/initramfs-tools/scripts/functions	2010-06-08 12:10:38.000000000 +0200
+++ /usr/share/initramfs-tools/scripts/functions	2010-06-10 14:50:25.822262987 +0200
@@ -285,13 +285,10 @@
 	local FS FSTYPE FSSIZE RET
 	FS="${1}"
 
-	# vol_id has a more complete list of file systems,
-	# but fstype is more robust
+	# blk_id has a more complete list of file systems, but fstype is more robust
 	eval $(fstype "${FS}" 2> /dev/null)
 	if [ "$FSTYPE" = "unknown" ] &&  command -v blkid >/dev/null 2>&1 ; then
 		FSTYPE=$(blkid -o value -s TYPE "${FS}")
-	elif [ "$FSTYPE" = "unknown" ] && [ -x /lib/udev/vol_id ]; then
-		FSTYPE=$(/lib/udev/vol_id -t "${FS}" 2> /dev/null)
 	fi
 	RET=$?

--- End Message ---
--- Begin Message --- 
On Thu, 10 Jun 2010, Christoph Anton Mitterer wrote:

> May I suggest to drop the code from get_fstype in /usr/share/initramfs-tools/scripts/functions
> that uses vol_id.
> 
> AFAIK vol_id is no longer available in udev or any other Debian package,
> so this is dead code.

it may be dead code, but it hurts nobody and I prefer to keep at least
one distribution backward compatibility. It helps on distribution upgrades
and peoples with mixed setups. Squeeze is not yet released and thus the
current stable is using vol_id. So I'd think it is reasonable to axe it
after the Wheezy release.

The comment got updated and we will axe the vol_id referred code,
added fixme notice on the vol_id invocation in preinst.
 
> Attached is a patch for this.
> 

Closing in order to cleanup the initramfs-tools bug reports.

Anyway thanks for the patch and happy 2011.

-- 
maks

--- End Message ---
Reply to: