[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#607368: marked as done (linux-2.6: silent ABI change in 2.6.32.26 breaks external modules (smp_ops changes))



Your message dated Sat, 18 Dec 2010 20:35:25 +0000
with message-id <20101218203525.GG17034@vostochny.stro.at>
and subject line Re: Bug#607368: Kernel ABI management
has caused the Debian Bug report #607368,
regarding linux-2.6: silent ABI change in 2.6.32.26 breaks external modules (smp_ops changes)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
607368: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607368
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: linux-2.6
Version: 2.6.32-28
Severity: serious

Hi,

smp_ops was changed in a rather incompatible way in 2.6.32.26, breaking 
the kernel ABI:

diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
index 4cfc908..4c2f63c 100644
--- a/arch/x86/include/asm/smp.h
+++ b/arch/x86/include/asm/smp.h
@@ -50,7 +50,7 @@ struct smp_ops {
        void (*smp_prepare_cpus)(unsigned max_cpus);
        void (*smp_cpus_done)(unsigned max_cpus);
 
-       void (*smp_send_stop)(void);
+       void (*stop_other_cpus)(int wait);
        void (*smp_send_reschedule)(int cpu);
 
        int (*cpu_up)(unsigned cpu);

This change was, in turn, willfully ignored (SVN rev 16598) and the kernel 
ABI remained at 5.

This breaks external modules like VMware (vmmon) that use the smp_ops 
symbol.

Please revert or bump the kernel ABI to 6 to reflect this ABI change.

Thanks,

JB.

-- 
Consultant INTM - Debian Developer - TMI Calibre
EDF - DSP - CSP IT - ITS Rhône Alpes - C4S - CCNPS
04 69 65 68 56




Ce message et toutes les pièces jointes (ci-après le 'Message') sont établis à l'intention exclusive des destinataires et les informations qui y figurent sont strictement confidentielles. Toute utilisation de ce Message non conforme à sa destination, toute diffusion ou toute publication totale ou partielle, est interdite sauf autorisation expresse.

Si vous n'êtes pas le destinataire de ce Message, il vous est interdit de le copier, de le faire suivre, de le divulguer ou d'en utiliser tout ou partie. Si vous avez reçu ce Message par erreur, merci de le supprimer de votre système, ainsi que toutes ses copies, et de n'en garder aucune trace sur quelque support que ce soit. Nous vous remercions également d'en avertir immédiatement l'expéditeur par retour du message.

Il est impossible de garantir que les communications par messagerie électronique arrivent en temps utile, sont sécurisées ou dénuées de toute erreur ou virus.
____________________________________________________

This message and any attachments (the 'Message') are intended solely for the addressees. The information contained in this Message is confidential. Any use of information contained in this Message not in accord with its purpose, any dissemination or disclosure, either whole or partial, is prohibited except formal approval.

If you are not the addressee, you may not copy, forward, disclose or use any part of it. If you have received this message in error, please delete it and all copies from your system and notify the sender immediately by return message.

E-mail communication cannot be guaranteed to be timely secure, error or virus-free.




--- End Message ---
--- Begin Message ---
On Sat, Dec 18, 2010 at 06:23:20PM +0100, Julien BLACHE wrote:
> Ben Hutchings <ben@decadent.org.uk> wrote:
> 
> >> This is reinforced by reading the packaging scripts and realizing they
> >> check the whole ABI, prior to -28.
> >
> > This is not correct.  We have ignored many changes since 2.6.32-12 when
> > the ABI number was bumped to 5.  In 2.6.32-27 the symbol version files
> > were refreshed and the ignore list was reset.
> 
> This is even more troubling.

no it is reality, please wakeup.

We never supported oot binary crap, nor do we intend to do.
closing, as you already got all the explanations.

-- 
maks


--- End Message ---

Reply to: