Re: [PATCHv2] Kbuild: kconfig: Verbose version of --listnewconfig

[Arnaud Lacombe <lacombar@gmail.com>]

Hi,

On Sat, Dec 4, 2010 at 1:30 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> [...]
>> > +       sym = menu->sym;
>> > +       if (sym && (sym->flags & SYMBOL_NEW) &&
>> > +           sym_is_changable(sym) && sym->name && !sym_is_choice_value(sym)) {
>> > +               if (verbose)
>> > +                       conf_write_symbol(sym, sym->type, stdout, true);
>> > +               else
>> > +                       printf("CONFIG_%s\n", sym->name);
>> Please don't hardcode the prefix string. This should be:
>>
>>                        printf("%s%s\n", CONFIG_, sym->name);
>
> OK, but I don't understand why it would change.
>
the Linux kernel is not the only user of kconfig.

 - Arnaud