[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#602450: firmware-nonfree: Please add rtlwifi/rtl8712u.bin, needed by r8712u >= 2.6.37, to firmware-realtek



Package: firmware-nonfree
Version: 0.27
Severity: wishlist

Hi

Starting with kernel 2.6.37, rtl8192su/ r8192s_usb will be replaced by 
the new staging driver rtl8712/ r8712u. It would be nice if its firmware,
which has been added to firmware-linux.git this week, could be added to 
the firmware-realtek package.
	http://lkml.indiana.edu/hypermail/linux/kernel/1011.0/00610.html
	Message-ID: <4cd014ec.e0Ho4xDM0+TOv1XT%Larry.Finger@lwfinger.net>
	http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=tree;f=rtlwifi

The firmware license appears to be acceptable for firmware-nonfree
	http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=blob;f=LICENCE.rtlwifi_firmware.txt


-- 
Hints for linux-2.6 2.6.37~
r8712u as merged mainline for 2.6.37 does not use this external firmware
yet, but still compiles it into the r8712u kernel module through
	drivers/staging/rtl8712/farray.h   (rm)

Patches to employ request_firmware() are pending
	http://www.spinics.net/lists/linux-wireless/msg58214.html
	Message-ID: <4CC9F4BE.7070500@lwfinger.net>

and a minor (updated in this attachment) fixup attached
	http://www.spinics.net/lists/linux-wireless/msg58240.html
	Message-Id: <201010292203.39953.s.L-H@gmx.de>

I can confirm that rtl8712/ r8712u with split out firmware using 
request_firmware() is working with RealTek RTL8188S and RTL8191S
devices and a decent replacement/ update for rtl8192su/ r8192s_usb.
	http://www.spinics.net/lists/linux-wireless/msg58239.html
	Message-Id: <201010292202.25486.s.L-H@gmx.de>

Regards
	Stefan Lippers-Hollmann
staging: r8712u: Fix external firmware loading

* select FW_LOADER
* declare MODULE_FIRMWARE for r8712u
* change firmware location to represent published linux-fimware.git

Signed-off-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
---
 drivers/staging/rtl8712/Kconfig    |    1 +
 drivers/staging/rtl8712/hal_init.c |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/staging/rtl8712/Kconfig
+++ b/drivers/staging/rtl8712/Kconfig
@@ -3,6 +3,7 @@ config R8712U
 	depends on WLAN && USB
 	select WIRELESS_EXT
 	select WEXT_PRIV
+	select FW_LOADER
 	default N
 	---help---
 	This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -40,7 +40,7 @@ static u32 rtl871x_open_fw(struct _adapt
 		    const u8 **ppmappedfw)
 {
 	int rc;
-	const char firmware_file[] = "rtl8712u/rtl8712u.bin";
+	const char firmware_file[] = "rtlwifi/rtl8712u.bin";
 	const struct firmware **praw = (const struct firmware **)
 				       (pphfwfile_hdl);
 	struct dvobj_priv *pdvobjpriv = (struct dvobj_priv *)
@@ -58,6 +58,7 @@ static u32 rtl871x_open_fw(struct _adapt
 	*ppmappedfw = (u8 *)((*praw)->data);
 	return (*praw)->size;
 }
+MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
 
 static void fill_fwpriv(struct _adapter *padapter, struct fw_priv *pfwpriv)
 {

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: