Bug#600155: [11/17] r6040: Fix multicast list iteration when hash filter is used
- To: Jack Stone <jwjstone@fastmail.fm>
- Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Florian Fainelli <florian@openwrt.org>, stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, 600155@bugs.debian.org, Jason Heeris <jason.heeris@gmail.com>, David Miller <davem@davemloft.net>, spamalot@hispeed.ch, Ben Hutchings <ben@decadent.org.uk>
- Subject: Bug#600155: [11/17] r6040: Fix multicast list iteration when hash filter is used
- From: Greg KH <gregkh@suse.de>
- Date: Fri, 22 Oct 2010 12:23:50 -0700
- Message-id: <[🔎] 20101022192350.GA10673@suse.de>
- Reply-to: Greg KH <gregkh@suse.de>, 600155@bugs.debian.org
- In-reply-to: <[🔎] 4CC1E257.4070704@fastmail.fm>
- References: <[🔎] 20101022184033.486292826@clark.site> <[🔎] 4CC1E257.4070704@fastmail.fm>
On Fri, Oct 22, 2010 at 08:13:27PM +0100, Jack Stone wrote:
> On 22/10/2010 19:39, Greg KH wrote:
> > drivers/net/r6040.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- a/drivers/net/r6040.c
> > +++ b/drivers/net/r6040.c
> > @@ -976,6 +976,7 @@ static void r6040_multicast_list(struct
> > iowrite16(hash_table[3], ioaddr + MAR3);
> > }
> > /* Multicast Address 1~4 case */
> > + dmi = dev->mc_list;
> > for (i = 0, dmi; (i < dev->mc_count) && (i < MCAST_MAX); i++) {
> Any reason for the dmi in the above line? As far as I can see it is a
> nop.
Look closer at the for loop please.
thanks,
greg k-h
Reply to: