Re: mlock/guard page/xen-tools & lenny
On Tue, 2010-08-31 at 11:00 +0100, Ian Campbell wrote:
> On Mon, 2010-08-30 at 22:57 -0600, dann frazier wrote:
> > On Mon, Aug 30, 2010 at 08:22:23AM -0600, dann frazier wrote:
> > > hey Ian,
> > > I haven't seen any reports of xen problems w/ the latest lenny DSA
> > > that added the guard page code. I looked at backporting the 3 patches
> > > from Linus - but the mlock patch touches code that didn't exist in
> > > .26, so I'm wondering if that patch is just not needed.
> >
> > fyi, I setup a Xen/lenny system and didn't have any problems w/
> > save/restore, so we're good afaict :)
>
> Thanks, I can't see code in the Lenny kernel equivalent to that which
> was broken either.
>
> I wrote a pretty skanky test program to test for the issue (mlock.c,
> attached, run with "./mlock lock" to trigger the issue). I don't have a
> Lenny system to hand right not where I can run it but if you still have
> a Lenny system setup then it might be interesting to try. (the test
> program doesn't actually require Xen to demonstrate the issue so any
> Lenny system should do).
I installed up a Lenny VM and ran the test case there and it did
fail :-(.
However, unless we come across a report of an actual failure with the
real toolstack I don't think it is worth worrying about.
Ian.
--
Ian Campbell
May the fleas of a thousand camels infest your armpits.
Reply to: