On Wed, 2010-08-25 at 13:20 +0100, Ian Campbell wrote: > On Wed, 2010-08-25 at 13:07 +0100, Ben Hutchings wrote: > > On Wed, 2010-08-25 at 09:54 +0100, Ian Campbell wrote: > > > On Wed, 2010-08-25 at 07:11 +0100, Ian Campbell wrote: > > > > On Wed, 2010-08-25 at 01:13 +0100, Ben Hutchings wrote: > > > > > I have had to revert the addition of pvhvm because it causes > > > > > an instant panic under KVM (at least in a 64-bit kernel). > > > > > > > > Ouch, I didn't think to try that combo! > > > > > > > > I don't suppose you managed to catch the stack anywhere? I'll try and > > > > repro today. > > > > > > So the fix is pretty simple (and the omission pretty embarrassing) but I > > > guess you'd prefer me to wait until after 2.6.32-21 before I update the > > > patches? > > [...] > > > > I'm not going to restart the build now, but we can reenable them in -22. > > Sure. Feel free to do that now. > > Relatedly, why did you set CONFIG_XEN_PLATFORM_PCI=y and not =m? It's > > generally preferable to enable features as modules where possible so > > they don't waste memory for users that don't need them. > > I did set it =m at first but there is no explicit dependency between > e.g. net-blkfront and the platform-pci driver so things like mkinitramfs > would not pick it up automatically without modifications to the > userspace stuff. > > The module is ~1.7k so I figured building it in was a worthwhile > trade-off in this case. (actually, I think this size includes init text > +data etc, looking at objdump -h the final size looks to be .text 0xc0 > + .data 0xe0 + .bss 0x20 + .rodata 0x168 = ~0.8k total) OK, that's not too bad. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part