Re: [PATCH] Nuke a few easily Lintian warnings
On Tue, Aug 17, 2010 at 07:41:47AM +0100, Ian Campbell wrote:
> dbg-package-missing-depends
> Add dependency on the corresponding linux-image package to each
> -dbg package. It's possible this is not appropriate for a kernel
> -dbg in which case I could make it an override instead.
No, the debug files have no dependency on the real package.
> Shall I apply? I guess if so then something similar ought to go into
> trunk (I was looking at the sid branch)
Please start with trunk.
> --- a/linux-2.6/debian/bin/gencontrol.py
> +++ b/linux-2.6/debian/bin/gencontrol.py
> - extra['headers_arch_depends'] = packages_headers_arch[-1]['Depends'] = PackageRelation()
> + packages_headers_arch[-1]['Depends'].extend(PackageRelation())
> + extra['headers_arch_depends'] = packages_headers_arch[-1]['Depends']
What is this supposed to do?
> --- a/linux-2.6/debian/templates/control.headers.arch.in
> +++ b/linux-2.6/debian/templates/control.headers.arch.in
> @@ -1,13 +1,14 @@
> Package: linux-headers-@upstreamversion@@abiname@-all
> -Depends: linux-headers-@upstreamversion@@abiname@-all-${kernel:Arch} (= ${binary:Version})
> +Depends: linux-headers-@upstreamversion@@abiname@-all-${kernel:Arch} (= ${binary:Version}), ${misc:Depends}
This is weird, this package does not even use debconf.
> +Depends: ${misc:Depends}
The same.
> --- a/linux-2.6/debian/templates/control.headers.featureset.in
> +++ b/linux-2.6/debian/templates/control.headers.featureset.in
> @@ -1,4 +1,5 @@
> Package: linux-headers-@upstreamversion@@abiname@-common@localversion_headers@
> +Depends: ${misc:Depends}
The same.
> --- a/linux-2.6/debian/templates/control.headers.in
> +++ b/linux-2.6/debian/templates/control.headers.in
> @@ -1,5 +1,5 @@
> Package: linux-headers-@upstreamversion@@abiname@@localversion@
> -Depends: linux-headers-@upstreamversion@@abiname@-common@localversion_headers@ (= ${binary:Version}), linux-kbuild-@version@
> +Depends: linux-headers-@upstreamversion@@abiname@-common@localversion_headers@ (= ${binary:Version}), linux-kbuild-@version@, ${misc:Depends}
Again.
> --- a/linux-2.6/debian/templates/control.image-dbg.in
> +++ b/linux-2.6/debian/templates/control.image-dbg.in
> @@ -1,4 +1,5 @@
> Package: linux-image-@upstreamversion@@abiname@@localversion@-dbg
> +Depends: linux-image-@upstreamversion@@abiname@@localversion@, ${misc:Depends}
No.
> --- a/linux-2.6/debian/templates/control.image.type-kernel-package.in
> +++ b/linux-2.6/debian/templates/control.image.type-kernel-package.in
> -Depends: module-init-tools
> +Depends: module-init-tools, ${misc:Depends}
Okay.
> --- a/linux-2.6/debian/templates/control.image.type-modulesextra.in
> +++ b/linux-2.6/debian/templates/control.image.type-modulesextra.in
Unused.
> @@ -1,11 +1,11 @@
> Package: linux-modules-@upstreamversion@@abiname@@localversion@
> -Depends: module-init-tools
> +Depends: module-init-tools, ${misc:Depends}
No debconf.
> --- a/linux-2.6/debian/templates/control.libc-dev.in
> +++ b/linux-2.6/debian/templates/control.libc-dev.in
> @@ -1,5 +1,6 @@
> Package: linux-libc-dev
> Section: devel
> +Depends: ${misc:Depends}
No debconf.
> --- a/linux-2.6/debian/templates/control.main.in
> +++ b/linux-2.6/debian/templates/control.main.in
> @@ -14,7 +14,7 @@ Package: linux-source-@version@
> Architecture: all
> Section: kernel
> Provides: linux-source, linux-source-@major@
> -Depends: binutils, bzip2
> +Depends: binutils, bzip2, ${misc:Depends}
No debconf.
> Package: linux-doc-@version@
> Architecture: all
> +Depends: ${misc:Depends}
No debconf.
--
We'll pivot at warp 2 and bring all tubes to bear, Mr. Sulu!
Reply to: