[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#396388: marked as done (should allow hooks to abort build)

Your message dated Fri, 18 Jun 2010 13:18:23 +0000
with message-id <E1OPbSh-00076q-DW@ries.debian.org>
and subject line Bug#396388: fixed in initramfs-tools 0.97
has caused the Debian Bug report #396388,
regarding should allow hooks to abort build
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
396388: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=396388
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.84
Severity: normal

mkinitramfs is not a set -x script, and so when call_scripts runs a hook
script, any error is ignored.

In some cases, a hook script needs to abort the initramfs build. For
example, then nslu2-tools hook script can detect issues, like a missing
ixp ethernet driver, that will make the box unusable, and needs to be
able to abort the initramfs build in these situations.

Currently the only way for a hook script to abort the build is a nasty
hack. Since call_scripts sources /conf/param.conf, a hook script could
create that file, and make it exit 1. Of course, that's beyond gross,
and I won't do it. :-)

Please provide a mechanism for hook scripts to abort a build. Note that
in the past, if a hook script exited nonzero, the build did abort, so my
guess is that there are few hook scripts that exit nonzero in cases
where the build would continue. However, if you don't feel that's safe
now, an alternative would be to check for a flag file in the initramfs
tree, which a hook script could create to indicate that the build needs
to be aborted.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.97

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.97.dsc
  to main/i/initramfs-tools/initramfs-tools_0.97.dsc
initramfs-tools_0.97.tar.gz
  to main/i/initramfs-tools/initramfs-tools_0.97.tar.gz
initramfs-tools_0.97_all.deb
  to main/i/initramfs-tools/initramfs-tools_0.97_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 396388@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Prokop <mika@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 18 Jun 2010 12:28:04 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.97
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Michael Prokop <mika@debian.org>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 396388 537139 582858 583695 585991 585992
Changes: 
 initramfs-tools (0.97) unstable; urgency=low
 .
   [ Martin Michlmayr ]
   * [e65ee48] Produce an error when root cannot be determined with
     MODULES=dep
   * [bb66fc2] hook-functions/init/scripts/local: add support for ubifs.
     (Closes: #582858) - thanks to Martin Michlmayr <tbm@cyrius.com>
 .
   [ Ferenc Wagner ]
   * [1d66ae1] scripts/nfs: cleanup retry logic
 .
   [ Colin Watson ]
   * [3054e3e] initramfs-tools: work around 'find -printf %Y' bug
 .
   [ maximilian attems ]
   * [a8a5ce4] script: Add update-initramfs.conf to bug report
   * [cc6077a] update-initramfs: Fix another unbound variable (Closes:
     #583695)
   * [b1f74e6] get_fstype: reference blkid in comment - thanks to
     Christoph Anton Mitterer <calestyo@scientia.net>
   * [eb93a7e] pre_mountroot(): reduce timeout to 30 seconds
   * [38563fe] scripts/functions: On panic change to tty1 if chvt around
     - thanks to Colin Watson <cjwatson@ubuntu.com>
   * [2031379] mkinitramfs: No point in hardcoding busybox path
   * [68c87cd] mkinitramfs: check syntax of boot and hook scripts
   * [ae02e4b] scripts/functions: beautify a bit reduce_satisfied()
   * [22d996c] maintainer doc: use git commands without the dash
   * [6147641] nfsmount: more small cleanups
   * [e967b03] mkinitramfs, lsinitramfs: Better error message for
     non-GNU getopt
   * Add lsinitramfs (to list content of an initramfs image) ([a39db63]
     [969f8fd] [fafede5] [2f3eb88])
 .
   [ Michael Prokop ]
   * [2a8c990] hook-functions/mkinitramfs/update-initramfs: consequently
     output error messages to stderr
   * [04b8619] init: display warning message if devtmpfs could not be
     mounted. - thanks to Ferenc Wagner <wferi@niif.hu>
   * [60afd2a] code cleanup: drop trailing whitespaces.
   * [ab28c77] code cleanup: consequently replace spaces in indentions
     with tabs to unify coding stile
   * [3a02c6f] code cleanup: consequently use "W:" for warnings.
   * [b1fff5e] add bash-completion for update-initramfs (Closes: #537139)
     - thanks to Stéphane Jourdois <stephane@jourdois.fr>
   * [5697c3b] hook-functions: replace awk calls with sed in
     dep_add_modules() (Closes: #585991) - thanks to Thorsten Glaser
     <tg@mirbsd.de>
   * [7afab22] debian/script: append /proc/mdstat (iff present) to
     bugreports
   * [5b565be] scripts/functions: allow hooks to abort build (Closes:
     #396388)
   * [528ba78] hook-functions: do not install ubi module by default via
     auto_add_modules()
   * [ecb8416] lsinitramfs: be more defensive against cmdline options
   * [2ff4ba2] scripts/functions: fix usage of test for script execution
   * [74f71c9] scripts/functions: fix another sh -n usage and fix typo
   * [91f5947] hook-functions: install virtio_pci module if
     /sys/bus/virtio is present and using modules=dep (Closes: #585992) -
     thanks to Vincent Danjean <vdanjean@debian.org>
   * [d25f610] slightly improve manpage lsinitramfs.8
   * Provide maintainer-notes.html, being "Maintainer documentation for
     initramfs-tools" ([7fc1ee5] [afafea4] [e506ee7] [d53a839] [6af23c2])
Checksums-Sha1: 
 1981a3c7cab77b8105606ef699b5a13c0d799dcf 948 initramfs-tools_0.97.dsc
 7d37400d055f5ba5300e6f735f3d5e34071fd155 78260 initramfs-tools_0.97.tar.gz
 1a24451b10f59779d1576587384e400b16177175 84888 initramfs-tools_0.97_all.deb
Checksums-Sha256: 
 e76167d657258eca81e156ebde6d3319855590acd8af1148dbb3055fe84e18fa 948 initramfs-tools_0.97.dsc
 682ab981a4a8ab489270e964ddd425beb29130a44b2a6b55e17a568f13ae0052 78260 initramfs-tools_0.97.tar.gz
 56eb56d472d0dd24c8f2fd030222586e258ec882b716f02d114865cef9c19639 84888 initramfs-tools_0.97_all.deb
Files: 
 4ef4180e40efded6fbfb0a76be43e3d1 948 utils optional initramfs-tools_0.97.dsc
 1d1d4885c8cdd5fd04dc899f91f9e361 78260 utils optional initramfs-tools_0.97.tar.gz
 10b97d7b5557007e5667d7a2f00c0539 84888 utils optional initramfs-tools_0.97_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMG2rG2N9T+zficugRAvHWAJ9KKRsrGl/l3yYiN6vg0M7RO5lVHQCffvVO
zRoO9DJoNULpxZd7GbUuen0=
=SfJe
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: