Re: Bug#585661: linux-2.6: support for gobi 2000 WWAN devices

[Bjørn Mork <bjorn@mork.no>]

Mark Hymers <mhy@debian.org> writes:
> On Tue, 15, Jun, 2010 at 01:44:45AM +0100, Ben Hutchings spoke thus..
>
>> > @@ -610,7 +610,7 @@
>> >  	for (i = 0; i < serial->num_ports; i++) {
>> >  		port = serial->port[i];
>> >  		if (!port->interrupt_in_urb) {
>> > -			dbg("%s: No interrupt URB for port %d\n", __func__, i);
>> > +			dbg("%s: No interrupt URB for port %d", __func__, i);
>> 
>> The newline should definitely be included, though this is not really
>> important.
>
> It was merged upstream without the newline.

Probably because include/linux/usb/serial.h has this:

/* Use our own dbg macro */
#undef dbg
#define dbg(format, arg...)                                             \
do {                                                                    \
        if (debug)                                                      \
                printk(KERN_DEBUG "%s: " format "\n", __FILE__, ##arg); \
} while (0)



Bjørn