tags 537139 + pending thanks * David Paleino <dapal@debian.org> [Fri Jun 11, 2010 at 11:48:58AM +0200]: > On Tue, 8 Jun 2010 14:42:07 +0200, Michael Prokop wrote: > > dear Bash Completion Maintainers, can you please check out the > > attached bash completion (#537139)? I'm not a bash user and can't > > judge whether that's the way to go or anything should be changed. > Sure: > > > -------------------------------------------------- > > > # update-initramfs(8) completion > > > # provided by Stéphane (kwisatz) Jourdois <stephane@jourdois.fr> > > > _update_initramfs() > > > { > > > local cur prev valid_options [...] > The only "suggestion" I can give is to also add "all" to the completion of "-k". > You can achieve this by adding, after _kernel_versions: > COMPREPLY=( $( compgen -W '${COMPREPLY[@]} all' -- "$cur" ) ) > This way you add "all" to the list of completions given by "_kernel_versions". > Other than this, it seems quite fine to me. Thanks! > However, we're going to release bash-completion 1.2 very soon (probably this > week-end) -- in that case, you can also change the initial lines, from: > cur=`_get_cword` > prev=${COMP_WORDS[COMP_CWORD-1]} > to: > _get_comp_words_by_ref cur prev > Remember that this will be available only on >= 1.2. So, depending on when > you're going to upload it, you might want to use one of those versions. Ok, won't include that as I don't want to depend on bash-completion >= 1.2. Commited in branch mika/bash-completion: http://git.debian.org/?p=kernel/initramfs-tools.git;a=shortlog;h=refs/heads/mika/bash-completion Will be pushed and uploaded if ACK-ed by other initramfs-tools maintainer. > > Should we add this to package initramfs-tools or would you mind > > adding it to bash-completion? > Please add it to your package, and install it using dh_bash-completion(1) if > you can :) Hm, I'd like to avoid build-depend on bash-completion. Wouldn't it make sense to add dh_bash-completion to debhelper package? regards, -mika-
Attachment:
signature.asc
Description: Digital signature