[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#396388: should allow hooks to abort build

* maximilian attems <max@stro.at> [Wed Jun 09, 2010 at 04:26:08AM +0200]:
> On Tue, Jun 08, 2010 at 03:32:32PM +0200, Michael Prokop wrote:
> > * Joey Hess <joeyh@debian.org> [Tue Oct 31, 2006 at 01:39:55PM -0500]:

> > > Please provide a mechanism for hook scripts to abort a build. Note that
> > > in the past, if a hook script exited nonzero, the build did abort, so my
> > > guess is that there are few hook scripts that exit nonzero in cases
> > > where the build would continue. However, if you don't feel that's safe
> > > now, an alternative would be to check for a flag file in the initramfs
> > > tree, which a hook script could create to indicate that the build needs
> > > to be aborted.

> > A "set -e ... set +e" inside call_scripts() would be sufficient
> > AFAICS as the existing scripts seem to exit != 0 only iff there's a
> > real problem. So we should just honor that and if people need a more
> > flexible way we could provide it as well later on.

> > maks, any objections against adding "set -e"? I'd take care of it.

> please not too many changes just before release,
> there are strange hook scripts out there.

It costed me quite some time in fixing things in automated builds
because the hooks didn't work as expected but i-t returned with exit
code 0. So IMO this would be an important Q/A step we should take
into consideration for Squeeze. Let's discuss that if you're back.


Attachment: signature.asc
Description: Digital signature

Reply to: