--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: initramfs-tools: copy_exec hook function may exit with a non-zero return value in non-verbose mode
- From: Gerrit Keller <gerrit.keller@gmail.com>
- Date: Fri, 04 Jun 2010 11:23:21 +0200
- Message-id: <20100604092321.9716.89606.reportbug@gerrit.local>
Package: initramfs-tools
Version: 0.95.1
Severity: normal
Tags: patch
copy_exec hook function may exit with a non-zero return value in non-verbose
mode
The copy_exec hook function could exit with a return value of 1 in non-verbose
mode. This happens due to the last command being
[ "${verbose}" = "y" ] && echo "Adding library ${x}"
whose return value will be used as the return value for the function. This
makes hook scripts with a 'set -e' statement abort after the call (see bug
#578065).
I've attached a trivial patch which fixes the problem.
-- Package-specific info:
-- initramfs sizes
-rw-r--r-- 1 root root 4.9M Jun 4 11:10 /boot/initrd.img-2.6.34
-- /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-2.6.34 root=UUID=1c5015ac-38a3-4dc1-a3fa-415f489efc3d
ro quiet resume=/dev/sdb2 splash
-- resume
RESUME=LABEL=swap
-- /proc/filesystems
ext3
fuseblk
-- lsmod
Module Size Used by
af_packet 14540 2
sco 5944 2
bnep 7628 2
rfcomm 25836 8
l2cap 27992 16 bnep,rfcomm
fuse 46096 3
vboxdrv 135400 0
asb100 8084 0
hwmon_vid 1836 1 asb100
hwmon 896 1 asb100
loop 10168 0
snd_cmipci 20512 2
snd_pcm 45716 1 snd_cmipci
snd_page_alloc 4820 1 snd_pcm
snd_opl3_lib 5964 1 snd_cmipci
snd_hwdep 4016 1 snd_opl3_lib
snd_mpu401_uart 3692 1 snd_cmipci
snd_seq_midi 3200 0
snd_seq_midi_event 3628 1 snd_seq_midi
btusb 8288 2
snd_rawmidi 13568 2 snd_mpu401_uart,snd_seq_midi
bluetooth 38404 9 sco,bnep,rfcomm,l2cap,btusb
snd_seq 33136 2 snd_seq_midi,snd_seq_midi_event
snd_timer 13936 3 snd_pcm,snd_opl3_lib,snd_seq
snd_seq_device 3384 4 snd_opl3_lib,snd_seq_midi,snd_rawmidi,snd_seq
sg 18652 0
sr_mod 9796 0
snd 31204 13
snd_cmipci,snd_pcm,snd_opl3_lib,snd_hwdep,snd_mpu401_uart,snd_rawmidi,snd_seq,snd_timer,snd_seq_device
cdrom 28032 1 sr_mod
soundcore 4000 1 snd
evdev 6144 7
i2c_viapro 4832 0
uhci_hcd 17848 0
8139too 15568 0
via_agp 4364 1
mii 2924 1 8139too
nouveau 454640 2
ttm 33948 1 nouveau
drm_kms_helper 21292 1 nouveau
drm 114464 4 nouveau,ttm,drm_kms_helper
agpgart 19036 3 via_agp,ttm,drm
firmware_class 4692 1 nouveau
i2c_algo_bit 3728 1 nouveau
i2c_core 12064 6
asb100,i2c_viapro,nouveau,drm_kms_helper,drm,i2c_algo_bit
button 2880 1 nouveau
unix 18508 646
-- /etc/kernel-img.conf
# Kernel image management overrides
# See kernel-img.conf(5) for details
do_symlinks = no
relative_links = yes
do_bootloader = no
do_bootfloppy = no
do_initrd = yes
link_in_boot = no
postinst_hook = /usr/sbin/update-grub
postrm_hook = /usr/sbin/update-grub
-- /etc/initramfs-tools/initramfs.conf
MODULES=dep
BUSYBOX=y
KEYMAP=n
COMPRESS=gzip
BOOT=local
DEVICE=
NFSROOT=auto
-- /sys/block
loop0
loop1
loop2
loop3
loop4
loop5
loop6
loop7
sda
sdb
sdc
sr0
sr1
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.34 (PREEMPT)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages initramfs-tools depends on:
ii cpio 2.11-4 GNU cpio -- a program to manage ar
ii findutils 4.4.2-1 utilities for finding files--find,
ii klibc-utils 1.5.18-1 small utilities built with klibc f
ii module-init-tools 3.12~pre2-3 tools for managing Linux kernel mo
ii udev 154-1 /dev/ and hotplug management daemo
Versions of packages initramfs-tools recommends:
pn busybox | busybox-initramfs <none> (no description available)
initramfs-tools suggests no packages.
-- Configuration Files:
/etc/initramfs-tools/initramfs.conf changed [not included]
--- hook-functions.orig 2010-05-30 20:46:00.000000000 +0200
+++ hook-functions 2010-06-04 11:02:58.000000000 +0200
@@ -148,7 +148,7 @@
mkdir -p "${DESTDIR}/${dirname}"
if [ ! -e "${DESTDIR}/${dirname}/${libname}" ]; then
ln -s "${x}" "${DESTDIR}/${dirname}"
- [ "${verbose}" = "y" ] && echo "Adding library ${x}"
+ [ "${verbose}" = "y" ] && echo "Adding library ${x}" || true
fi
done
}
--- End Message ---
--- Begin Message ---
Source: initramfs-tools
Source-Version: 0.96.1
We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:
initramfs-tools_0.96.1.dsc
to main/i/initramfs-tools/initramfs-tools_0.96.1.dsc
initramfs-tools_0.96.1.tar.gz
to main/i/initramfs-tools/initramfs-tools_0.96.1.tar.gz
initramfs-tools_0.96.1_all.deb
to main/i/initramfs-tools/initramfs-tools_0.96.1_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 584520@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Prokop <mika@debian.org> (supplier of updated initramfs-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 08 Jun 2010 15:59:08 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.96.1
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Michael Prokop <mika@debian.org>
Description:
initramfs-tools - tools for generating an initramfs
Closes: 439846 514756 549680 566056 576678 584520
Changes:
initramfs-tools (0.96.1) unstable; urgency=low
.
* hook-functions: Make sure copy_exec hook function does not
exit with a non-zero return value in non-verbose mode.
[Closes: #584520]
* docs/framebuffer: Document mode vs. mode_option option in
framebuffer example script. [Closes: #439846]
* hook-functions: make device name handling for /proc/mdstat
more flexible for MODULES=dep. [Closes: #549680, #514756]
* mkinitramfs / scripts/functions + initramfs-tools.8:
Support dashes inside scripts names. [Closes: #566056]
* hook-functions: handle ubifs in dep_add_modules() and return
since ubifs root is a char device, (see issue #582858).
* mkinitramfs: warn if TMPDIR is mounted noexec + fall back
to not cache run scripts then. [Closes: #576678]
* Add myself to uploaders.
Checksums-Sha1:
d2ca68eba46f9c1b657f2c548ad40dc22072ae95 956 initramfs-tools_0.96.1.dsc
65f8e68b47df99d07bf05bf8fdd0bfcd538d59ff 72727 initramfs-tools_0.96.1.tar.gz
55072e505650c0899721fbb27ec864ce13544338 78782 initramfs-tools_0.96.1_all.deb
Checksums-Sha256:
b3f0e77371a4024514debbb85208143b84622eee098d378be19f2f7bc44779ab 956 initramfs-tools_0.96.1.dsc
70354f9716a402cd3976db9b6dcc47c930283b936bd3b4488cf29d7bee06428e 72727 initramfs-tools_0.96.1.tar.gz
a71d6c1853e82f0077034af1b8cc83f28795d8e353bf391b92be2a49655d7dcf 78782 initramfs-tools_0.96.1_all.deb
Files:
840e650183a79a09e71ffc323190a14a 956 utils optional initramfs-tools_0.96.1.dsc
e9beb8eba07bfaa83f526fdf9dbcd4f3 72727 utils optional initramfs-tools_0.96.1.tar.gz
dc7f9fc53f2ca3eb8e09415c5d961641 78782 utils optional initramfs-tools_0.96.1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFMDl3z2N9T+zficugRAq9kAJ9pZi/7CxyL6pp4CPbsdX3wJycdeQCfbyGy
Auc4PISNwUlPG//g0FK3BKs=
=swkl
-----END PGP SIGNATURE-----
--- End Message ---