[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#582281: Promised utility now available



reassign 582281 linux-2.6
tags 582281 + upstream
quit

Stephen Powell wrote:

> Now, how do you want to work this?  Do you (the Debian Kernel Team)
> want to function as an intermediary between me and upstream?
> Or would you prefer that I report the problem to upstream myself?

I am not the kernel team, but for issues in upstream code, it is
_always_ a good idea to go to upstream directly[1].

 $ grep '^[0-9]*)' Documentation/SubmittingPatches
 1) "diff -up"
 2) Describe your changes.
 3) Separate your changes.
 4) Style check your changes.
 5) Select e-mail destination.
 6) Select your CC (e-mail carbon copy) list.
 7) No MIME, no links, no compression, no attachments.  Just plain text.
 8) E-mail size.
 9) Name your kernel version.
 10) Don't get discouraged.  Re-submit.
 11) Include PATCH in the subject
 12) Sign your work
 13) When to use Acked-by: and Cc:
 14) Using Reported-by:, Tested-by: and Reviewed-by:
 15) The canonical patch format
 16) Sending "git pull" requests  (from Linus emails)
 1) Read Documentation/CodingStyle
 2) #ifdefs are ugly
 3) 'static inline' is better than a macro
 4) Don't over-design.
 $ scripts/get_maintainer.pl -f fs/partitions/ibm.c
 "Martin K. Petersen" <martin.petersen@oracle.com>
 Jens Axboe <jens.axboe@oracle.com>
 linux-kernel@vger.kernel.org

Summary: the best thing is to send your patch as a _unified_ diff
(i.e. generated with diff -u), and include it inline in a message
to the addresses listed above, with the following format:

 some timeless words about the patch

 Signed-off-by line (see Documentation/SubmittingPatches for what
 this means and why)
 ---
 some timely words about the patch 

 the patch (diff -up output)

It seems I have only been able to make more work for you lately.
Sorry.  I would also be willing to pass on the patch myself, but at
minimum this requires your signed-off-by line, and it might be good to
get to know the process anyway.

You can see lots of examples at http://news.gmane.org/gmane.linux.kernel

Hope that helps,
Jonathan

[1] The corresponding Debian bug report is still useful, as a way to
track the status of the bug in Debian (e.g., what versions have the
patch applied).



Reply to: