[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#569034: linux-2.6: Please support sh4 architecture



Hi,

Thanks for your comments.

2010/2/10 Bastian Blank <waldi@debian.org>:
> On Wed, Feb 10, 2010 at 01:09:21AM +0900, Nobuhiro Iwamatsu wrote:
>>   s390
>>   sparc
>>   sparc64
>> + sh4
>> +
> Is there a reason why you don't maintain this list in a sorted way as
> it was before?

Fixed.

>
>> diff --git a/linux-2.6/debian/config/sh4/config b/linux-2.6/debian/config/sh4/config
>> new file mode 100644
>> index 0000000..e69de29
>
> This is most likely wrong. Every architecture have some common settings.
>

Fixed.
I moved common settings of  architecture to this file.

>> diff --git a/linux-2.6/debian/config/sh4/config.sh7785lcr b/linux-2.6/debian/config/sh4/config.sh7785lcr
>> new file mode 100644
>> index 0000000..d0163c7
>
> This is unacceptable, please provide a stripped down version that only
> contains the necessary stuff.

Fiexed.
I removed the information that was not necessary.

>
>> +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
>
> Why?
This was in debconfig of the kernel. I deleted it.

>
>> +CONFIG_EXT2_FS=y
>> +# CONFIG_EXT2_FS_XATTR is not set
>> +CONFIG_EXT3_FS=y
>> +# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
>> +CONFIG_EXT3_FS_XATTR=y
>> +# CONFIG_EXT3_FS_POSIX_ACL is not set
>> +# CONFIG_EXT3_FS_SECURITY is not set
>> +# CONFIG_EXT4_FS is not set
>
> No.

I enabled only CONFIG_EXT3_FS in config.sh7785lcr.

>
>> +# Kernel partition size: 4MB
>> +check-size: 4194304
>
> You mean MiB?
>
Yes.

I attached new patch.
Could you check ?

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

Attachment: 0001-Add-sh4-support.patch
Description: application/empty


Reply to: