Bug#534430: linux-image-2.6.26: CBQ broken
I think I found the breakage.
Have a look at cbq_set_lss()
Instead of checking the flags with && and working based on that it
actually ANDs the flags every time (which if the flag is not already set
results in an eternal false).
I am rebuilding it at the moment after replacing the offending & with
&&. If it works after that we can hopefully consider this one closed.
Brgds,
On Wed, 2010-01-27 at 10:49 +0000, Anton Ivanov wrote:
> I have finally gotten around to look at it properly (it has been
> annoying me all morning so I did not have choice, but to get to it).
>
> There is no way I can see the current kernel code to work.
>
> It sets borrow to be _ALWAYS_ equal to the parent on line 2077 of
> cbq_shed.c. For a bounded class it should change the used bandwidth in
> the parent as in the other bits of code around this part and after that
> set it to NULL. That bit of code is completely missing.
>
> I just downloaded 33-rc5 will look if it is there.
>
> Brgds,
>
--
Understanding is a three-edged sword:
your side, their side, and the truth. --Kosh Naranek
A. R. Ivanov
E-mail: aivanov@sigsegv.cx
WWW: http://www.sigsegv.cx/
pub 1024D/DDE5E715 2002-03-03 Anton R. Ivanov <arivanov@sigsegv.cx>
Fingerprint: C824 CBD7 EE4B D7F8 5331 89D5 FCDA 572E DDE5 E715
Reply to: