[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#563852: thinkpad_acpi: LED restriction does not add safety, please enable CONFIG_THINKPAD_ACPI_UNSAFE_LEDS

Package: linux-2.6
Severity: normal

The kernel guys decided it would be a good idea to cripple thinkpad_acpi by
not allowing the state of some hardware LEDs to be set, like the dock and
battery. They say that allowing these LEDs to be set can make users perform
actions dangerous to the hardware because firmware information might get lost.

I think that this change does not add safety at all, because the "unaware"
user which they reference in the docs doesn't play around with the LEDs anyway.
The LED devices are root writable only anyway, so evil guy wanting to destroy
other people's laptop could just load a fixed kernel module to control the
LEDs. The option is just a PITA for people that want to control the LEDs for
their own purposes, because they have to rebuild kernel modules. (No it's not
even a module load option like with the fan control switch, even though doing
funny things with the fan can cause much more damage to the hardware than
doing things to the LED.)

So there is no advantage in restricting access to the LEDs and therefore I'd
be thankful if future versions of the Debian kernel were built with

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Reply to: