[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#555835: [usb-storage] linux-image-2.6.30-2-686: Unusual usb storage Samsung YP-CP3 not working



On Wed, 18 Nov 2009, Moritz Muehlenhoff wrote:

> [CCing upstream for review/merge of the patch proposed by Vitaly.]
> 
> This was reported to Debian as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555835
> 
> Vitaly, please add a Signed-off-by: header as described in 
> Documentation/SubmittingPatches
> 
> Cheers,
>         Moritz

> > I wrote a small patch to fix this problem:
> > --- drivers/usb/storage/unusual_devs.h.old      2009-09-26 01:58:45.000000000 +0400
> > +++ drivers/usb/storage/unusual_devs.h  2009-11-12 02:01:20.000000000 +0300
> > @@ -495,6 +495,13 @@
> >                 US_SC_DEVICE, US_PR_DEVICE, NULL,
> >                 US_FL_MAX_SECTORS_64),
> >  
> > +/* Reported by Vitaly Kuznetsov <vitty@altlinux.ru> */
> > +UNUSUAL_DEV(  0x04e8, 0x5122, 0x0000, 0x9999,
> > +               "Samsung",
> > +               "YP-CP3",
> > +               US_SC_DEVICE, US_PR_DEVICE, NULL,
> > +               US_FL_MAX_SECTORS_64 | US_FL_FIX_INQUIRY | US_FL_FIX_CAPACITY | US_FL_BULK_IGNORE_TAG),

This is highly questionable.  How can you be sure all those flags are 
really needed?  Have you collected a usbmon trace to find out what's 
actually going wrong?

Alan Stern




Reply to: