On Mon, 04 May 2009 00:17:03 +0100 Ben Hutchings <ben@decadent.org.uk> wrote: > On Mon, 2009-04-20 at 21:45 -0600, dann frazier wrote: > > > > Kalle: would you mind submitting your patch upstream, if you haven't > > already? A lot of similar patches for other drives have been accepted > > in recent months. > > Kalle's patch has a serious problem in that it attempts to byte-swap the > firmware in place. On a big-endian system where the firmware is built > into the kernel, or if a cache is implemented, this will corrupt the > image or cause an oops. > I saw also that some drivers provide blobs as ihex files, a textual representation of the binary data, and convert it to a binary image at build time. Could this be useful in this case? > Furthermore, I think any patch sent upstream will need to handle the > "new" DSP code as well. > Indeed. > Anyway, here's my proposed patch for unstable (against 2.6.30-rc4) that > deals with the first problem. I'll have a go at handling the "new" DSP > code as well, but as I don't have the hardware for this driver this will > need testing by others. > I will test this patch soon; wrt the NEW DSP feature, I don't know if I can test everything, because I have a Thinkpad T20, only stereo output. BTW, what binary image to use? Is the one extracted with the tool in this thread, to be run on a little-endian host, ok? Thanks, Antonio -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? Web site: http://www.studenti.unina.it/~ospite Public key: http://www.studenti.unina.it/~ospite/aopubkey.asc
Attachment:
pgpUS7n2fYECi.pgp
Description: PGP signature