Bug#555835: [usb-storage] linux-image-2.6.30-2-686: Unusual usb storage Samsung YP-CP3 not working
Alan Stern <stern@rowland.harvard.edu> writes:
>> > +/* Reported by Vitaly Kuznetsov <vitty@altlinux.ru> */
>> > +UNUSUAL_DEV( 0x04e8, 0x5122, 0x0000, 0x9999,
>> > + "Samsung",
>> > + "YP-CP3",
>> > + US_SC_DEVICE, US_PR_DEVICE, NULL,
>> > + US_FL_MAX_SECTORS_64 | US_FL_FIX_INQUIRY | US_FL_FIX_CAPACITY |
> US_FL_BULK_IGNORE_TAG),
>
> This is highly questionable. How can you be sure all those flags are
> really needed? Have you collected a usbmon trace to find out what's
> actually going wrong?
>
> Alan Stern
Hello Alan,
as I answered Matthew Dharm yesterday this was not minimal set needed to
get device working properly.
Without US_FL_BULK_IGNORE_TAG:
Nov 20 01:17:56 vitbook kernel: [60336.044697] scsi 4:0:0:1:
Direct-Access Samsung YP-CP3 0000 PQ: 0 ANSI: 2
Nov 20 01:17:56 vitbook kernel: [60336.048770] sd 4:0:0:1: [sdc]
Attached SCSI removable disk
Nov 20 01:17:56 vitbook kernel: [60336.049266] sd 4:0:0:0: [sdb]
Adjusting the sector count from its reported value: 7649280
Nov 20 01:17:56 vitbook kernel: [60336.049280] sd 4:0:0:0: [sdb]
7649279 512-byte hardware sectors: (3.91 GB/3.64 GiB)
Nov 20 01:17:56 vitbook kernel: [60336.160052] usb 2-2: reset high
speed USB device using ehci_hcd and address 3
Nov 20 01:17:56 vitbook kernel: [60336.408080] usb 2-2: reset high
speed USB device using ehci_hcd and address 3
Nov 20 01:17:56 vitbook kernel: [60336.670754] usb 2-2: reset high
speed USB device using ehci_hcd and address 3
Nov 20 01:17:57 vitbook kernel: [60336.860493] usb 2-2: USB
disconnect, address 3
(devide does not work)
Without US_FL_FIX_CAPACITY works well,
Without US_FL_FIX_INQUIRY works well,
Without US_FL_MAX_SECTORS_64
Nov 20 01:31:43 vitbook kernel: [61162.880923] scsi 8:0:0:0:
Direct-Access SAMSUNG YP-CP3 1.00 PQ: 0 ANSI: 0
Nov 20 01:31:43 vitbook kernel: [61162.881796] scsi 8:0:0:1:
Direct-Access SAMSUNG microSD Card 1.00 PQ: 0 ANSI: 0 CCS
Nov 20 01:31:43 vitbook kernel: [61162.886339] sd 8:0:0:1: [sdc]
Attached SCSI removable disk
Nov 20 01:31:43 vitbook kernel: [61162.886757] sd 8:0:0:0: [sdb]
7649280 512-byte hardware sectors: (3.91 GB/3.64 GiB)
Nov 20 01:31:43 vitbook kernel: [61162.887247] sd 8:0:0:0: [sdb] Write
Protect is off
Nov 20 01:31:43 vitbook kernel: [61162.889637] sdb:
Nov 20 01:31:43 vitbook kernel: [61162.893457] sd 8:0:0:0: [sdb]
Attached SCSI removable disk
Nov 20 01:31:43 vitbook kernel: [61163.054984] sd 8:0:0:0: [sdb]
Unhandled error code
Nov 20 01:31:43 vitbook kernel: [61163.054993] sd 8:0:0:0: [sdb]
Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK
Nov 20 01:31:43 vitbook kernel: [61163.175881] sd 8:0:0:0: [sdb]
Unhandled error code
(device does not work)
So, the minimum is US_FL_MAX_SECTORS_64 | US_FL_BULK_IGNORE_TAG
New patch attached.
--
Vitaly Kuznetsov, ALT Linux.
>From ea56523a4edd65bdef9ba08dec03563f3638a35e Mon Sep 17 00:00:00 2001
From: Vitaly Kuznetsov <vitty@altlinux.ru>
Date: Thu, 19 Nov 2009 15:49:05 +0000
Subject: [PATCH] USB: Unusual Device support for Samsung YP-CP3 MP4 Player
User was getting the following errors in dmesg:
usb 2-6: reset high speed USB device using ehci_hcd and address 2
usb 2-6: reset high speed USB device using ehci_hcd and address 2
usb 2-6: reset high speed USB device using ehci_hcd and address 2
usb 2-6: USB disconnect, address 2
sd 3:0:0:0: [sdb] Assuming drive cache: write through
sdb:<2>ldm_validate_partition_table(): Disk read failed.
Dev sdb: unable to read RDB block 0
unable to read partition table
Signed-off-by: Vitaly Kuznetsov <vitty@altlinux.ru>
---
drivers/usb/storage/unusual_devs.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index d4f034e..05b0d2c 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -481,6 +481,13 @@ UNUSUAL_DEV( 0x04e8, 0x507c, 0x0220, 0x0220,
US_SC_DEVICE, US_PR_DEVICE, NULL,
US_FL_MAX_SECTORS_64),
+/* Reported by Vitaly Kuznetsov <vitty@altlinux.ru> */
+UNUSUAL_DEV( 0x04e8, 0x5122, 0x0000, 0x9999,
+ "Samsung",
+ "YP-CP3",
+ US_SC_DEVICE, US_PR_DEVICE, NULL,
+ US_FL_MAX_SECTORS_64 | US_FL_BULK_IGNORE_TAG),
+
/* Entry and supporting patch by Theodore Kilgore <kilgota@auburn.edu>.
* Device uses standards-violating 32-byte Bulk Command Block Wrappers and
* reports itself as "Proprietary SCSI Bulk." Cf. device entry 0x084d:0x0011.
--
1.6.3.3
Reply to: