On Wed, 2009-10-07 at 16:26 -0400, Dan Dennison wrote: > $ ls /boot/config* > /boot/config-2.6.18-6-amd64 /boot/config-2.6.29-2-amd64 > /boot/config-2.6.26-1-amd64 /boot/config-2.6.30-1-amd64 > > $ grep LBD /boot/config* > /boot/config-2.6.18-6-amd64:CONFIG_LBD=y CONFIG_LBD is irrelevant on 64-bit architectures. > Is it at all concerning that the sd driver tries a read capacity 16 > and fails? > > I propose the following sequence of events: > > 1) 'sd' block device tries to read capacity 16 and fails because > CONFIG_LBD is not asserted, defaulting to a size of 2TB > 2) 'hfsplus' then tries to mount this larger-than-2TB filesystem and > is successful > 3) Writes to this inappropriately mounted filesystem fail once they > run off of the edge > > I submit that the proposed patch is in error, and that hfsplus does > very well support >2TB filesystems on Linux. [...] For starters, hfsplus_get_block() calculates a sector number using 32-bit values. Even on 64-bit architectures. Ben. -- Ben Hutchings To err is human; to really foul things up requires a computer.
Attachment:
signature.asc
Description: This is a digitally signed message part