[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#523735: /etc/kernel/postinst.d/initramfs-tools: please consider supporting the experimental kernel-package out of the box



hello matthijs,

On Thu, Oct 01, 2009 at 09:50:18AM +0200, Matthijs Kooijman wrote:
> 
> > fixed in latest git, also added 2 small comment lines,
> > which should make code intent clearer, please review
> > happy to add/change them.
> 
> Hmm, I'm not so sure if this comment helps. The file now says
> 
>   # official linux-images take care themself
> 
> which would suggest this hook should _not_ run for official images, while it
> is quite the opposite. I'd write something like:

no it is not the opposite.
the hook should *not* be run for linux-images out of linux-2.6
they take care to run update-initramfs in their postinst.
those are the official and supported linux images in Debian.

homegrown kernel-package build are on their own.
but of course in the interest of cooperation this hooks exist also for
them. user need to made clear that the easy Debian way of building a
linux-image is to unpack a recent linux-2.6 tarball and run
make deb-pkg
 
>   # Don't run for kernels generated by older versions of kernel-package, since
>   # those took care of generating initramfs themselves (but didn't set
>   # KERNEL_PACKAGE_VERSION yet). See #523735. Always run for newer version of
>   # kernel-package and the official Debian kernels.

no aboves sentence is wrong (see above) and much too long.
 
> And perhaps a few lines up (where you set bootdir):
> 
>   # Kernel-package passes the path to the vmlinuz file as a second argument,
>   # which might not be in /boot.

well that is a strange feature anyway that i don't want
to feature too much.

kind regards
maks



Reply to: