[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#524300: linux-image-2.6.26-2-686: cannot turn wireless RF on/off on Asus U3S notebook when asus_acpi module is loaded



asus_acpi should fail on unsupported models.  There has been an upstream
change that implements this, which seems to be applicable to the lenny
kernel.

Ben.

commit 7745384080ef70f7710530afa3e45477b126e056
Author: Zhang Rui <rui.zhang@intel.com>
Date:   Fri Oct 17 01:42:41 2008 -0400

    don't load asus-acpi if model is not supported
    
    asus_hotk_get_info should return -ENODEV if the model is not supported.
    http://bugzilla.kernel.org/show_bug.cgi?id=10389
    
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
index 91571fc..428e47b 100644
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -1244,6 +1244,8 @@ static int asus_hotk_get_info(void)
 			       "default values\n", string);
 			printk(KERN_NOTICE
 			       "  send /proc/acpi/dsdt to the developers\n");
+			kfree(model);
+			return -ENODEV;
 		}
 		hotk->methods = &model_conf[hotk->model];
 		return AE_OK;
--- END ---

-- 
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: