[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#524928: initramfs-tools: wrong path for elilo



On Tue, Apr 21, 2009 at 02:44:16PM +0200, maximilian attems wrote:
> On Mon, 20 Apr 2009, Steve Langasek wrote:

> > On Mon, Apr 20, 2009 at 02:52:07PM -0600, dann frazier wrote:

> > > --- initramfs-tools-0.93.2/update-initramfs.orig	2009-04-20 14:50:15.000000000 -0600
> > > +++ initramfs-tools-0.93.2/update-initramfs	2009-04-20 14:50:28.000000000 -0600
> > > @@ -257,7 +257,7 @@
> > >  		run_lilo
> > >  		return 0
> > >  	fi
> > > -	if [ -x /sbin/elilo ]; then
> > > +	if [ -x /usr/sbin/elilo ]; then
> > >  		elilo
> > >  		return 0
> > >  	fi
> > 
> > Surely this should be if [ -x $(which elilo 2>/dev/null) ], since paths
> > aren't supposed to be hard-coded in maintainer scripts at all?

> thanks you both for the input will use
> command -v elilo >/dev/null 2>&1 

Is 'command -v' in SUSv3?  'which' is the predominant idiom used in
maintainer scripts...

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org



Reply to: