[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#509007: mkvmlinuz: force -fno-stack-protector



Package: mkvmlinuz
Version: 35
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch jaunty

Ubuntu uses -fstack-protector by default; this doesn't work for
standalone code like mkvmlinuz (https://bugs.launchpad.net/bugs/53460)
and so we need to explicitly compile with -fno-stack-protector. I know
this isn't an immediate problem for Debian, but would you consider
applying this patch anyway? It should be harmless.

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]
diff -Nru mkvmlinuz-35/boot/Makefile mkvmlinuz-35ubuntu1/boot/Makefile
--- mkvmlinuz-35/boot/Makefile	2008-02-29 20:25:23.000000000 +0000
+++ mkvmlinuz-35ubuntu1/boot/Makefile	2008-12-17 11:14:57.000000000 +0000
@@ -1,6 +1,7 @@
 GCC	:= gcc -m32
 CFLAGS	:= -Wall -Wstrict-prototypes -O2 -g -fomit-frame-pointer -fno-builtin \
-	   -nostdinc -isystem $(shell $(GCC) -print-file-name=include) -fPIC
+	   -nostdinc -isystem $(shell $(GCC) -print-file-name=include) -fPIC \
+	   -fno-stack-protector
 AFLAGS	:= -D__ASSEMBLY__ $(CFLAGS) -traditional -nostdinc
 
 src := crt0.S string.S prom.c stdio.c main.c div64.S

Reply to: