[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#494257: marked as done (Please make log_begin_msg not emit trailing newline)

Your message dated Tue, 12 Aug 2008 09:47:04 +0000
with message-id <E1KSqT2-0006Zi-6P@ries.debian.org>
and subject line Bug#494257: fixed in initramfs-tools 0.92f
has caused the Debian Bug report #494257,
regarding Please make log_begin_msg not emit trailing newline
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
494257: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494257
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.92e
Severity: minor
Tags: patch

Hi,

Please make log_begin_msg not emit a trailing newline - this makes the non-
"quiet" output cleaner and results in half as many lines being emitted. For
example:

  Begin: Finding root filesytem ...
  Done.

Becomes:

  Begin: Finding root filesytem ... done.

Patch attached - it also adds a space and alters the case of "done" for
symmetry. This would be especially useful in Debian Live where we show a
large number of these messages by default.


Regards,

-- 
Chris Lamb, UK                                       chris@chris-lamb.co.uk
                                                            GPG: 0x634F9A20

diff -urNad initramfs-tools-0.92e.orig/scripts/functions initramfs-tools-0.92e/scripts/functions
--- initramfs-tools-0.92e.orig/scripts/functions	2008-08-08 03:34:46.000000000 +0100
+++ initramfs-tools-0.92e/scripts/functions	2008-08-08 03:49:14.000000000 +0100
@@ -3,22 +3,22 @@
 _log_msg()
 {
 	if [ "$quiet" = "y" ]; then return; fi
-	echo "$@"
+	printf "$@"
 }
 
 log_success_msg()
 {
-	_log_msg "Success: $@"
+	_log_msg "Success: $@\n"
 }
 
 log_failure_msg()
 {
-	_log_msg "Failure: $@"
+	_log_msg "Failure: $@\n"
 }
 
 log_warning_msg()
 {
-	_log_msg "Warning: $@"
+	_log_msg "Warning: $@\n"
 }
 
 log_begin_msg()
@@ -26,7 +26,7 @@
 	if [ -x /sbin/usplash_write ]; then
 		/sbin/usplash_write "TEXT $@"
 	fi
-	_log_msg "Begin: $@ ..."
+	_log_msg "Begin: $@ ... "
 }
 
 log_end_msg()
@@ -34,7 +34,7 @@
 	if [ -x /sbin/usplash_write ]; then
 		/sbin/usplash_write "SUCCESS ok"
 	fi
-	_log_msg "Done."
+	_log_msg "done.\n"
 }
 
 panic()

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.92f

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.92f.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.92f.dsc
initramfs-tools_0.92f.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.92f.tar.gz
initramfs-tools_0.92f_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.92f_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 494257@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 12 Aug 2008 11:09:11 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.92f
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@debian.org>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 490875 493238 494027 494257 494433
Changes: 
 initramfs-tools (0.92f) unstable; urgency=medium
 .
   [ maximilian attems ]
   * mkinitramfs: only lvm2 initramfs has busybox dep. (closes: #490875)
   * mkinitramfs: Fix usage and man outfile arg is not optional.
     (closes: #493238)
   * preinst fix vol_id path. (closes: #494433)
   * update-initramfs: run_bootloader() invoke flash-kernel and glantank-
     update-kernel in order to have latest initramfs flashed on triggered
     update. Thanks to Joey Hess <joeyh@debian.org>.
   * debian/control: Newer standards version without changes.
 .
   [ Chris Lamb ]
   * make log_begin_msg not emit trailing newline (closes: #494257)
 .
   [ Martin Michlmayr ]
   * MODULES=dep boot fix for Orion. (closes: #494027)
Checksums-Sha1: 
 ab2beff55de10868126adc5d6c78b576960f3dc0 1004 initramfs-tools_0.92f.dsc
 ad5e9b9a909b67826312bbe0b7b5f5f634677dff 66586 initramfs-tools_0.92f.tar.gz
 e7a565d10f14b11a4ddfee0947d569ce9e90f7c2 73516 initramfs-tools_0.92f_all.deb
Checksums-Sha256: 
 1aa3b9bf25bcb12566aae815a31004d22fbeb1aeb7c16bce8e9e13f0521f69bb 1004 initramfs-tools_0.92f.dsc
 2444485ee4734068f2d9a2b3ae904f479954958d16fea5fdf58f4d73ce1b99e4 66586 initramfs-tools_0.92f.tar.gz
 4f7bc9c8234196f39ca5e3c4cce898461b67ec250d4210d244d6082757014251 73516 initramfs-tools_0.92f_all.deb
Files: 
 5fa85bead74fbaaa951e67c67fbef68e 1004 utils optional initramfs-tools_0.92f.dsc
 2484226382c931de4a144b5c954e7831 66586 utils optional initramfs-tools_0.92f.tar.gz
 080e14eb933888e4a1a29a6773be64b8 73516 utils optional initramfs-tools_0.92f_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkihWawACgkQeW7Lc5tEHqg5HACfbhqfgAISZsdwIxE23k4mnMx8
HoMAoLCBUiIUN33d46NjLmvZchhLgr8B
=ExM5
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: