[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#491149: initramfs-tools: panic() won't print error message



Package: initramfs-tools
Version: 0.92e
Severity: normal
Tags: patch

If the panic() function is invoked it should print a message
but it does not because stdout is not connected to the
console.

The fix is easy: just add a "> /dev/console" to the echo command.

I attach a patch, but it's probably easier to fix by hand.
Consider changing echo $@ > /dev/console to echo "$@" > /dev/console
(I don't know if it's a good idea, but it looks better; if you don't
want to protect $@ for whatever reason, $* would be philosophically
better).

    Thanks,

           Loïc Grenié

-- Package-specific info:
-- /proc/cmdline
auto BOOT_IMAGE=Linux23 ro root=806 resume=/dev/sda8 mem=4G quiet splash

-- /proc/filesystems
	ext3
	cramfs
	iso9660
	fuseblk

-- lsmod
Module                  Size  Used by
radeon                138384  2 
drm                   175952  3 radeon
video                  21972  0 
output                  4736  1 video
fan                     6152  0 
cpufreq_userspace       4972  0 
cpufreq_stats           6112  0 
nfs                   261208  0 
lockd                  68816  1 nfs
nfs_acl                 4160  1 nfs
sunrpc                184232  4 nfs,lockd,nfs_acl
af_packet              24204  2 
ipv6                  272296  28 
fuse                   48688  1 
eeprom                  8720  0 
kvm_amd                29452  0 
kvm                   139200  1 kvm_amd
snd_hda_intel         330212  1 
snd_pcm_oss            44320  0 
snd_mixer_oss          17280  1 snd_pcm_oss
snd_pcm                85640  2 snd_hda_intel,snd_pcm_oss
snd_timer              24712  1 snd_pcm
snd                    61752  7 snd_hda_intel,snd_pcm_oss,snd_mixer_oss,snd_pcm,snd_timer
sdhci                  19084  0 
ehci_hcd               34380  0 
ohci_hcd               22404  0 
soundcore               9104  1 snd
mmc_core               32648  1 sdhci
snd_page_alloc         11344  2 snd_hda_intel,snd_pcm
thermal                18272  0 
usbcore               151408  3 ehci_hcd,ohci_hcd

-- /etc/kernel-img.conf
do_symlinks = yes
relative_links = yes
do_bootloader = no
do_bootfloppy = no
do_initrd = yes
link_in_boot = no

-- /etc/initramfs-tools/initramfs.conf
MODULES=dep
BUSYBOX=y
KEYMAP=n
BOOT=local
DEVICE=eth0
NFSROOT=auto

-- /sys/block
hda
loop0
loop1
loop2
loop3
loop4
loop5
loop6
loop7
ram0
ram1
ram10
ram11
ram12
ram13
ram14
ram15
ram2
ram3
ram4
ram5
ram6
ram7
ram8
ram9
sda


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.23.14 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages initramfs-tools depends on:
ii  cpio                          2.9-13     GNU cpio -- a program to manage ar
ii  findutils                     4.4.0-2    utilities for finding files--find,
ii  klibc-utils                   1.5.11-3   small utilities built with klibc f
ii  module-init-tools             3.4-1      tools for managing Linux kernel mo
ii  udev                          0.114-2    /dev/ and hotplug management daemo

Versions of packages initramfs-tools recommends:
ii  busybox                       1:1.9.2-3  Tiny utilities for small and embed

-- no debconf information
diff -ur scripts.orig/functions scripts/functions
--- scripts.orig/functions	2008-07-05 02:09:51.000000000 +0200
+++ scripts/functions	2008-07-17 10:28:35.191804081 +0200
@@ -49,7 +49,7 @@
 	fi
 	modprobe i8042
 	modprobe atkbd
-	echo $@
+	echo $@ > /dev/console
 	PS1='(initramfs) ' /bin/sh -i </dev/console >/dev/console 2>&1
 }
 

Reply to: