[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#458772: marked as done (initramfs-tools: update-initramfs' check for ro-mounted /boot partitions yields false positives)

Your message dated Tue, 12 Feb 2008 17:32:06 +0000
with message-id <E1JOyzG-0001Qa-C3@ries.debian.org>
and subject line Bug#458772: fixed in initramfs-tools 0.91e
has caused the Debian Bug report #458772,
regarding initramfs-tools: update-initramfs' check for ro-mounted /boot partitions yields false positives
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
458772: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=458772
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.91c
Severity: normal
Tags: patch


Hi Kernel-Team,

i stumbled over this bug when I wanted to update my initrd while I had
some isos loop-mounted like this:


$ cat /proc/mounts |grep boot
/dev/hda1 /boot ext2 rw 0 0
/dev/loop57 /srv/pub/iso_loop/sys/bootrescue-cd-20071129-59 iso9660 ro 0
0
/dev/loop58 /srv/pub/iso_loop/sys/bootrescue-cd-dev iso9660 ro 0 0
/dev/loop59 /srv/pub/iso_loop/sys/bootrescue-dvd-20071129-59 iso9660 ro
0 0
/dev/loop60 /srv/pub/iso_loop/sys/bootrescue-dvd-dev iso9660 ro 0 0


The check for a ro-mounted /boot partition was falsly triggered by the
mount targets of the iso-images. As you can see in the patch attached,
for the conditional awk output to work as desired, another pair of hyphen
enclosing the awk match calls is required.

HTH,

Daniel Reichelt


*** tmp/update-initramfs.patch
--- update-initramfs	2007-11-28 19:42:10.000000000 +0100
+++ update-initramfs-new	2008-01-02 18:55:49.000000000 +0100
@@ -266,7 +266,7 @@
 		return 0
 	fi
 
-	boot_opts=$(awk '/boot/{if (match($4, /^ro/) || match($4, /,ro/) \
+	boot_opts=$(awk '/boot/{if ((match($4, /^ro/) || match($4, /,ro/)) \
 		&& $2 == "/boot") print "ro"}' /proc/mounts)
 	if [ -n "${boot_opts}" ]; then
 		echo "WARNING: /boot is ro mounted."


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.23.11-dhr (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages initramfs-tools depends on:
ii  cpio                         2.9-6       GNU cpio -- a program to manage ar
ii  klibc-utils                  1.5.7-4     small statically-linked utilities 
ii  module-init-tools            3.3-pre11-4 tools for managing Linux kernel mo
ii  udev                         0.114-2     /dev/ and hotplug management daemo

Versions of packages initramfs-tools recommends:
ii  busybox                       1:1.1.3-5  Tiny utilities for small and embed

--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.91e

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.91e.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.91e.dsc
initramfs-tools_0.91e.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.91e.tar.gz
initramfs-tools_0.91e_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.91e_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 458772@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 12 Feb 2008 18:23:34 +0100
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.91e
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@debian.org>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 458772
Changes: 
 initramfs-tools (0.91e) unstable; urgency=medium
 .
   [ Daniel Reichelt ]
   * update-initramfs: fix ro-mounted /boot check (closes: #458772)
Files: 
 6c81afda65e05967c4a7bfb8fe57fa05 782 utils optional initramfs-tools_0.91e.dsc
 ddb6df9781343c95406edc7767448a56 63916 utils optional initramfs-tools_0.91e.tar.gz
 4419514766602587c68e61a67ee0e4ca 70682 utils optional initramfs-tools_0.91e_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHsdZkeW7Lc5tEHqgRAvWOAKCwa8phvv5JUMrE+kT8mrvG/iC1pQCaAvjp
xSVnOOXfdkpNdcsIiniNSgE=
=yAVO
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: