Bug#446222: please integrate the em8300 module

[Daniel Baumann <daniel@debian.org>]

reassign 446222 em8300
thanks

Hi,

summing up:

  * em8300 builds now with m-a and 2.6.24-1
  * l-m-c-2.6 has the meta files of em8300
  * em8300 still with l-m-c-2.6

all you need to do is to fix the following error (from em8300 0.16.4-1):

---snip---
[...]
/usr/bin/make -f debian/rules.gen build_i386
make[1]: Entering directory `/home/user/linux-modules-contrib-2.6'
/usr/bin/make -f debian/rules.real build MAJOR='2.6'
MODULESOURCE='em8300-source' FLAVOUR='486' KERNEL_ARCH='x86'
UPSTREAMVERSION='2.6.24' MODULE='em8300' FEATURESET='none'
VERSION_SOURCE='2.6.24' VERSION='2.6.24' ABINAME='-1'
LOCALVERSION='-486' ARCH='i386' VERSION_DEBIAN='2'
make[2]: Entering directory `/home/user/linux-modules-contrib-2.6'
/usr/bin/make -C /usr/src/linux-headers-2.6.24-1-486
M=/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300

make[3]: Entering directory `/usr/src/linux-headers-2.6.24-1-486'
expr: non-numeric argument
  LD
/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/built-in.o
  CC [M]
/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/adv717x.o
  CC [M]
/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/bt865.o
/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/bt865.c:
In function 'bt865_setup':
/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/bt865.c:883:
error: expected expression before '==' token
/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/bt865.c:886:
error: expected expression before '==' token
make[4]: ***
[/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300/bt865.o]
Error 1
make[3]: ***
[_module_/home/user/linux-modules-contrib-2.6/debian/build/build_i386_none_486_em8300]
Error 2
make[3]: Leaving directory `/usr/src/linux-headers-2.6.24-1-486'
make[2]: *** [debian/stamps/build_i386_none_486_em8300] Error 2
make[2]: Leaving directory `/home/user/linux-modules-contrib-2.6'
make[1]: *** [build_i386_none_486_em8300] Error 2
make[1]: Leaving directory `/home/user/linux-modules-contrib-2.6'
make: *** [debian/stamps/build-base] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
(sid_i386)user@debian:~/linux-modules-contrib-2.6$
---snap---

For better undertanding what is happening:

  * l-m-c-2.6 unpacks em8300.tar.bz2 to a directory, and calls
    make the following way (BUILD_DIR is where the sources are unpacked
    to):
    $(MAKE) -C $(HEADERS_DIR) M=$(BUILD_DIR)

    similar, for installing the module, it calls:
    $(MAKE) -C $(HEADERS_DIR) M=$(BUILD_DIR) modules_install \
     INSTALL_MOD_PATH=$(PACKAGE_DIR) INSTALL_MOD_DIR=contrib/$(MODULE)

  * your source package needs a top-level makefile which conforms to
    these two make calls. any extra variables, such as special compiler
    flags or configuration flags need to be present in that very
    makefile.

  * to avoid duplication, it is recommended to also make use of the
    top-level makefile in your debian/rules, by just calling it there.

  * a sample package to look at is btrfs and aufs.

Regards,
Daniel

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/