Bug#461754: linux-modules-extra-2.6: Please add loop-aes
Hi Daniel,
On Sun, Jan 20, 2008 at 04:31:57PM +0100, Daniel Baumann wrote:
> Max Vozeler wrote:
> > The attached patch adds loop-aes modules - tested
> > with r10149 and 2.6.24-rc8.
>
> thanks for integrating loop-aes into l-m-e.
>
> Why do you override stuff in loop-aes/rules?
I'm preparing a small kbuild-based source tree in the
setup target override because it is not possible to
get the loop-AES build system to work here (see below).
> Ideally, this shouldn't be
> needed and be done in the module-source itself (means, the
> Makefile of your loop-aes-source package).
Agreed - ideally it should be done in the module source.
I originally tried to adapt the loop-AES build system
but then decided against it for several reasons:
o It does funky stuff during build time, like rename
files based on the kernel version being used.
o This is done to keep support for building against
very old kernels way back to 2.0.x.
o I couldn't find a way to make the build system work
like a normal kbuild-based build system without
breaking support for the earlier kernels.
o Upstream considers backwards compatibility important
and some users of loop-aes-source rely on it.
o Certain MAKEFLAGS in linux-modules-extra-2.6 break
the original loop-AES Makefile.
I concluded it was not possible to integrate the
loop-AES build system with lme-2.6 in a sane way and
decided to replace it with a small and clean kbuild
Makefile - this is what the override is doing.
I could probably prepare the kbuild-based tree in
loop-aes-source, but then it would be something like
"/usr/src/modules/loop-aes/build-tree-for-lme-2.6" -
it would only be used for lme-2.6.
Max
Reply to: