Bug#458772: initramfs-tools: update-initramfs' check for ro-mounted /boot partitions yields false positives
Package: initramfs-tools
Version: 0.91c
Severity: normal
Tags: patch
Hi Kernel-Team,
i stumbled over this bug when I wanted to update my initrd while I had
some isos loop-mounted like this:
$ cat /proc/mounts |grep boot
/dev/hda1 /boot ext2 rw 0 0
/dev/loop57 /srv/pub/iso_loop/sys/bootrescue-cd-20071129-59 iso9660 ro 0
0
/dev/loop58 /srv/pub/iso_loop/sys/bootrescue-cd-dev iso9660 ro 0 0
/dev/loop59 /srv/pub/iso_loop/sys/bootrescue-dvd-20071129-59 iso9660 ro
0 0
/dev/loop60 /srv/pub/iso_loop/sys/bootrescue-dvd-dev iso9660 ro 0 0
The check for a ro-mounted /boot partition was falsly triggered by the
mount targets of the iso-images. As you can see in the patch attached,
for the conditional awk output to work as desired, another pair of hyphen
enclosing the awk match calls is required.
HTH,
Daniel Reichelt
*** tmp/update-initramfs.patch
--- update-initramfs 2007-11-28 19:42:10.000000000 +0100
+++ update-initramfs-new 2008-01-02 18:55:49.000000000 +0100
@@ -266,7 +266,7 @@
return 0
fi
- boot_opts=$(awk '/boot/{if (match($4, /^ro/) || match($4, /,ro/) \
+ boot_opts=$(awk '/boot/{if ((match($4, /^ro/) || match($4, /,ro/)) \
&& $2 == "/boot") print "ro"}' /proc/mounts)
if [ -n "${boot_opts}" ]; then
echo "WARNING: /boot is ro mounted."
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.23.11-dhr (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages initramfs-tools depends on:
ii cpio 2.9-6 GNU cpio -- a program to manage ar
ii klibc-utils 1.5.7-4 small statically-linked utilities
ii module-init-tools 3.3-pre11-4 tools for managing Linux kernel mo
ii udev 0.114-2 /dev/ and hotplug management daemo
Versions of packages initramfs-tools recommends:
ii busybox 1:1.1.3-5 Tiny utilities for small and embed
Reply to: