Bug#433459: initramfs-tools: add error messages about ignored files in hooks directory

[maximilian attems <max@stro.at>]

tags 433459 pending
stop

On Tue, 17 Jul 2007, Kornilios Kourtis wrote:

> 
> Something like the following patch would have saved me some debugging time.

 
> --- scripts/functions.old	2007-05-29 01:13:06.000000000 +0300
> +++ scripts/functions	2007-07-17 14:43:17.000000000 +0300
> @@ -88,15 +88,18 @@
>  		# only allow variable name chars
>  		case ${si_x#${initdir}/} in
>  		*[![:alnum:]_]*)
> +			echo "$si_x ignored: only alphanumeric or '_' allowed in filename"
>  			continue
>  			;;
>  		esac
>  		# skip non executable scripts
>  		if [ ! -x ${si_x} ]; then
> +			echo "$si_x ignored: not executable"
>  			continue
>  		fi
>  		# skip directories
>  		if [ -d ${si_x} ]; then
> +			echo "$si_x ignored: its a directory"
>  			continue
>  		fi
>  		initlist="${initlist} ${si_x#${initdir}/}"
> 
> Please consider applying it.

thanks your patch showed that set_initlist was called twice.
fixed that plus 80 char width of the messages.

also empty dirs needs to be skipped without warning.

plus the ouput should be only be echo'd on verbose
mode as it might confuse usplash on initramfs boot for example.
see latest git
http://git.debian.org/?p=kernel/initramfs-tools.git;a=summary

regards

-- 
maks