[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#392592: a simpler patch



On Thu, Jan 04, 2007 at 01:21:25AM +0100, Bastian Blank wrote:
> > My primary concern is that, in the future, the output of these scripts
> > will change and we (or our successors) will either not notice or
> > forget to update the hardcoded values.
> 
> Thats why I say you should remove the code completely; it is not longer
> possible to change it without getting completely different results.

Can you restate this sentence? I don't follow what the "it" is we
cannot change, or what the different results are.

At any rate, I have committed the change you requested, but still
disagree with the approach. It requires maintaining a patch
indefinitely against upstream in order to workaround a self-imposed
packaging issue. If these scripts were under the generic scripts
directory, I highly doubt their use would be under scrutiny.

-- 
dann frazier




Reply to: