Re: [patch] dmfe installer problems

[maximilian attems <max@stro.at>]

hello florian,

On Sun, Dec 09, 2007 at 11:18:23AM +0100, Florian Lohoff wrote:
> 
> Hi,
> in #454618 and #360699 we have reports about failed installs on the Sun
> Netra X1. This is caused by the dmfe driver claiming an incompatible
> device (due to the same PCI ID for compatible and incompatible device).
> 
> The tulip driver has some logic to refuse to touch the problematic dmfe
> devices:
> 
> drivers/net/tulip_core.c
> 1279         /*
> 1280          *      Early DM9100's need software CRC and the DMFE driver
> 1281          */
> 1282 
> 1283         if (pdev->vendor == 0x1282 && pdev->device == 0x9100)
> 1284         {
> 1285                 /* Read Chip revision */
> 1286                 if (pdev->revision < 0x30)
> 1287                 {
> 1288                         printk(KERN_ERR PFX "skipping early DM9100 with Crc bug (use dmfe)\n");
> 1289                         return -ENODEV;
> 1290                 }
> 1291         }
> 
> but dmfe doesnt. So dmfe claims the tulip devices but fails to work with
> them. One of the symptoms is that it fails to read the mac address and
> sets an all 0 MAC address.
> 
> I would propose a patch like this (only compile tested): 

care to post that new revision to netdev and cc akpm,
so that it gets some spins on -mm too.

looks much better then
Message-ID: <20071208111749.GA20529@paradigm.rfc822.org>

once picked in mm i'll push it to our trunk too.

thanks

--
maks