[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#433190: marked as done (inhibit /etc/initramfs-tools/conf.d/resume creation in chroot)



Your message dated Thu, 09 Aug 2007 20:47:05 +0000
with message-id <E1IJEuP-0002KM-GR@ries.debian.org>
and subject line Bug#433190: fixed in initramfs-tools 0.90
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: initramfs-tools
Version: 0.89
Severity: wishlist
Tags: patch

Hi maks,

When installing initramfs-tools in a chroot, I'd like to propose 
that /etc/initramfs-tools/conf.d/resume not be created.

debian-live and other custom debian distributions build their system up in a 
chroot environment, therefore it is not good for the resulting 
initramfs-tools generated initial ramdisk to be configured for the system 
that hosted the original chroot.

Plus, who can use suspend in a chroot environment? ;-)

Patch is attached. chrooted() function borrowed from udev's postinst.

Thanks, Kel.
diff -Nrup initramfs-tools-0.89/debian/initramfs-tools.preinst initramfs-tools-0.89-patched/debian/initramfs-tools.preinst
--- initramfs-tools-0.89/debian/initramfs-tools.preinst	2007-05-29 08:00:39.000000000 +1000
+++ initramfs-tools-0.89-patched/debian/initramfs-tools.preinst	2007-07-15 18:47:16.000000000 +1000
@@ -2,6 +2,16 @@
 
 set -e
 
+chrooted() {
+	# borrowed from udev's postinst
+	if [ "$(stat -c %d/%i /)" = "$(stat -Lc %d/%i /proc/1/root 2>/dev/null)" ]; then
+		# the devicenumber/inode pair of / is the same as that of /sbin/init's
+		# root, so we're *not* in a chroot and hence return false.
+		return 1
+	fi
+	return 0
+}
+
 case "$1" in
 	install)
 		mkdir -p /etc/initramfs-tools/conf.d
@@ -15,7 +25,8 @@ case "$1" in
 		if [ -e /etc/mkinitrd/mkinitrd.conf ]; then
 			 . /etc/mkinitrd/mkinitrd.conf
 		fi
-		if [ -n "${RESUME}" ]; then
+		# write conf.d/resume if not in a chroot
+		if [ -n "${RESUME}" ] && ! chrooted; then
 			echo "RESUME=${RESUME}" > /etc/initramfs-tools/conf.d/resume
 		fi
 

--- End Message ---
--- Begin Message ---
Source: initramfs-tools
Source-Version: 0.90

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.90.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.90.dsc
initramfs-tools_0.90.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.90.tar.gz
initramfs-tools_0.90_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.90_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 433190@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 09 Aug 2007 21:30:29 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.90
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@debian.org>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 420754 425050 426446 426917 428729 429237 433190 433459 435031 436752
Changes: 
 initramfs-tools (0.90) unstable; urgency=low
 .
   Release "J'aim' pas le fataliste Je n'ai ni foi ni loi"
 .
   [ maximilian attems ]
   * hook-functions: Fix xen i386 boots with optimized 2.5. (closes: 420754)
     Thanks Marco Nenciarini <mnencia@debian.org> for patch.
   * debian/control: Bump dep on klibc-utils from etch. (closes: 435031)
   * scripts/functions: Implement non-zero panic bootarg. Style fix for
     maybe_break().
   * hook-functions: dep_add_modules() fix for md, lv, luks root.
     (closes: #426917, #429237, #426446)
   * debian/scripts: Add /etc/crypttab to reportbug script.  Add /sys/block
     list for MODULES=dep to reportbug script.
   * scripts/functions: Add error message on verbose mode about ignored files
     in boot/hooks dir.  Thanks Kornilios Kourtis <kkourt@cslab.ece.ntua.gr>
     for the initial patch. Fixes a double set_initlist call too. Ignore empty
     dirs earlier too. (closes: #428729, #433459)
   * mkinitramfs.8: Document verbose mode.
   * debian/initramfs-tools.preinst: Inhibit /etc/initramfs-tools/conf.d/resume
     creation in chroot for debian-live and other. (closes: #433190)
     Thanks Kel Modderman <kel@otaku42.de> for the patch.
   * update-initramfs: Improve "altered" error message. (closes: #436752)
   * update-initramfs, update-initramfs.conf: update_initramfs config variable
     is tristate. Set to 'all' to update any initramfs: $(update-initramfs -u).
     Allows specific admin setting. (closes: #425050)
 .
   [ David Härdeman ]
   * hook-functions: Protect all variable with local, plus coding style fixes.
Files: 
 fcea65851e626dc6c1c3a3da43172bf1 656 utils optional initramfs-tools_0.90.dsc
 9e6e6d34c5fd676a8ee3fe3fdb975744 60995 utils optional initramfs-tools_0.90.tar.gz
 f93b1c026cfeefe9d48e866eb89bc444 68036 utils optional initramfs-tools_0.90_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGu2uVeW7Lc5tEHqgRAs1JAJ9ca9d+JDQMnbRbUKpv4MwrmjGjYwCghDUI
FhqmhhKdKsIkxIQApJYjPno=
=Mq50
-----END PGP SIGNATURE-----


--- End Message ---

Reply to: