[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#354453: marked as done ([benh@kernel.crashing.org: [PATCH] powerpc: vdso 64bits gettimeofday bug])

Your message dated Sat, 4 Aug 2007 02:36:22 +0200
with message-id <20070804003622.GA8734@stro.at>
and subject line [benh@kernel.crashing.org: [PATCH] powerpc: vdso 64bits gettimeofday bug]
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: linux-2.6

----- Forwarded message from Benjamin Herrenschmidt <benh@kernel.crashing.org> -----

Subject: [PATCH] powerpc: vdso 64bits gettimeofday bug
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: Paul Mackerras <paulus@samba.org>, Olaf Hering <olh@suse.de>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
	Greg KH <greg@kroah.com>, David Woodhouse <dwmw2@infradead.org>,
	Sven Luther <sven.luther@wanadoo.fr>
Date: Sun, 26 Feb 2006 08:09:00 +1100
Message-Id: <1140901740.24957.29.camel@localhost.localdomain>
X-Mailer: Evolution 2.5.91 

A bug in the assembly code of the vdso can cause gettimeofday() to hang
or to return incorrect results. The wrong register was used to test for
pending updates of the calibration variables and to create a dependency
for subsequent loads. This fixes it.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Might be worth applying to the stable series too and/or distro kernels
2.6.15 and later

--- linux-work.orig/arch/powerpc/kernel/vdso64/gettimeofday.S	2006-02-26 08:02:57.000000000 +1100
+++ linux-work/arch/powerpc/kernel/vdso64/gettimeofday.S	2006-02-26 08:04:23.000000000 +1100
@@ -225,9 +225,9 @@
   .cfi_startproc
 	/* check for update count & load values */
 1:	ld	r8,CFG_TB_UPDATE_COUNT(r3)
-	andi.	r0,r4,1			/* pending update ? loop */
+	andi.	r0,r8,1			/* pending update ? loop */
 	bne-	1b
-	xor	r0,r4,r4		/* create dependency */
+	xor	r0,r8,r8		/* create dependency */
 	add	r3,r3,r0
 
 	/* Get TB & offset it */


---------------------------------------------------------------------------------------
Wanadoo vous informe que cet  e-mail a ete controle par l'anti-virus mail. 
Aucun virus connu a ce jour par nos services n'a ete detecte.




----- End forwarded message -----

--- End Message ---
--- Begin Message --- 
Package: linux-2.6
Version: 2.6.16-1


patch landed upstream,
long fixed since.


-- 
maks

--- End Message ---
Reply to: