[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#428729: does not execute all scripts in /etc/initramfs-tools/scripts/local-top

hello marc,

On Wed, 13 Jun 2007, Marc Haber wrote:

> Hi,
> The regexp used to decide whether a script in
> /etc/initramfs-tools/scripts/local-top/prelvm2 gets executed or not is
> considerably more restrictive than the code found in other packages,
> such as in run-parts. For example, they allow hyphens in the file
> name, while initramfs-tools does not.

hmm afaik dash don't allows '~' as a variable name,
that is the kriterium i'm interested in?

-- dash(1)
     Variables set by the user must have a name consisting solely of alphabet-
     ics, numerics, and underscores - the first of which must not be numeric.
so hmm it seems our check are not restrictive enough,
as we dont check for a script 10foo

> This is kind of a surprise.
> On a second thought, it might be a good idea to print debug output
> like "not using pre-lvm2 for initrd because of illegal character - in
> file name".

yes this makes sense on debug/verbose mode.
thanks for feedback.


Reply to: