[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#383248: [Fwd: New package available]



David Härdeman <david@hardeman.nu> writes:

> Great, and once you do, feel free to add it as a git repo to
> git.debian.org and give me commit access then all of us can use that repo
> as the main one instead of my home-grown git repo.

I have some trivial but useful changes to recommend:

 - Makefile shouldn't have the executable bit;
 - You should use debhelper compatibility 5 instead of 4 (see man
   debhelper);
 - I would have used cdbs instead of plain debhelper but it's my
   personal preference;

All the rest looks OK. All those changes are trivial and can be kept
for the next version if wanted. I think it's a green light for its
uploading ;-)

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



Reply to: