[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#404107: [PATCH] [linux-image-2.6.18-3-686] sky2 crashes on boot or resume



On Thu, Mar 22, 2007 at 07:57:34AM -0300, Renato S. Yamane wrote:
> 
> Please, test this patch below.
> Thanks to Stephen Hemminger!
> 

Doesnt help - Broke this morning on first boot ...

Mar 23 07:31:47 localhost kernel: [   26.568000] sky2 eth1: enabling interface
Mar 23 07:31:47 localhost kernel: [   26.572000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.576000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.576000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.580000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.584000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.584000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.588000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.588000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.592000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.592000] sky2 eth1: phy write timeout
Mar 23 07:31:47 localhost kernel: [   26.592000] sky2 eth1: ram buffer 1020K

After a reboot (without powering down) everything is fine ...

Flo

> ---
>  drivers/net/sky2.c |   11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> --- sky2-dev.orig/drivers/net/sky2.c	2007-03-19 14:28:00.000000000 -0700
> +++ sky2-dev/drivers/net/sky2.c	2007-03-19 15:24:16.000000000 -0700
> @@ -2489,9 +2489,13 @@
>  {
>  	u8 t8;
> 
> +	hw->chip_id = sky2_read8(hw, B2_CHIP_ID);
> +	/* Make sure and enable all clocks */
> +	if (hw->chip_id == CHIP_ID_YUKON_EX || hw->chip_id == CHIP_ID_YUKON_EC_U)
> +		sky2_pci_write32(hw, PCI_DEV_REG3, 0);
> +
>  	sky2_write8(hw, B0_CTST, CS_RST_CLR);
> 
> -	hw->chip_id = sky2_read8(hw, B2_CHIP_ID);
>  	if (hw->chip_id < CHIP_ID_YUKON_XL || hw->chip_id > CHIP_ID_YUKON_FE) {
>  		dev_err(&hw->pdev->dev, "unsupported chip type 0x%x\n",
>  			hw->chip_id);
> @@ -2501,11 +2505,6 @@
>  	if (hw->chip_id == CHIP_ID_YUKON_EX)
>  		dev_warn(&hw->pdev->dev, "this driver not yet tested on this chip type\n"
>  			 "Please report success or failure to <netdev@vger.kernel.org>\n");
> -
> -	/* Make sure and enable all clocks */
> -	if (hw->chip_id == CHIP_ID_YUKON_EX || hw->chip_id == CHIP_ID_YUKON_EC_U)
> -		sky2_pci_write32(hw, PCI_DEV_REG3, 0);
> -
>  	hw->chip_rev = (sky2_read8(hw, B2_MAC_CFG) & CFG_CHIP_R_MSK) >> 4;
> 
>  	/* This rev is really old, and requires untested workarounds */

-- 
Florian Lohoff                  flo@rfc822.org             +49-171-2280134
	Those who would give up a little freedom to get a little 
          security shall soon have neither - Benjamin Franklin

Attachment: signature.asc
Description: Digital signature


Reply to: