Bug#338405: another patch
tags 338405 wontfix
stop
On Sun, 31 Dec 2006, Russell Coker wrote:
> The attached patch creates a new config option ONLY_BUSYBOX which can be set
> if you want to use busybox instead of kinit. It saves over 200K of
> compressed size on my system.
>
> I believe that this should be included, it doesn't stop kinit being used,
> merely provides another option.
well the patch description is different to the patch itself.
kinit is not used in initramfs-tools and is not removed in
the patch below, what you remove are dash and minips from klibc-utils.
> --- /usr/sbin/mkinitramfs 2006-12-20 02:22:05.000000000 +1100
> +++ mkinitramfs 2006-12-31 13:08:52.000000000 +1100
> @@ -229,7 +229,15 @@
> rm -f ${DESTDIR}/bin/sh
> rm -f ${DESTDIR}/bin/busybox
> copy_exec ${BUSYBOXDIR}/busybox /bin/busybox
> - ln -s ${BUSYBOXDIR}/busybox ${DESTDIR}/bin/sh
> + if [ "x${ONLY_BUSYBOX}" = "xn" -o "x${ONLY_BUSYBOX}" = "x" ]; then
> + ln -s ${BUSYBOXDIR}/busybox ${DESTDIR}/bin/sh
> + else
> + rm ${DESTDIR}/bin/busybox ${DESTDIR}/bin/sh.shared ${DESTDIR}/bin/minips
> + cp ${BUSYBOXDIR}/busybox ${DESTDIR}/bin/busybox
> + for n in `busybox | tail -19 | tr , \\\\n | sed -e "s/ \|\t//"|grep .|grep -v busybox` ; do
> + ln -f ${DESTDIR}/bin/busybox ${DESTDIR}/bin/$n
> + done
> + fi
> fi
>
> # Modutils
no this patch has the same fundamental problems than the one
that was merged for 0.85d.
* ugly: once busybox has a busybox --list, there would be no need
to invoke tail, tr, sed and grep.
* wrong: the busybox counterparts to the klibc-utils are not functinality
equivalent. as written in the changelog documenting the revert for
example sleep doesn't take subsecond args. quite sure that there is
other breakage too as experienced by the sheer number of boot failures of
0.85d.
--
maks
Reply to: