Re: [patch, attach, RFC] usb-serial: ti_usb removing firmware
Oleg --
Some comments. I will be away until next Tuesday, when I can do
more with this.
* We can't remove the compiled in firmware--that would break things
until users get and install the firmware images.
* What I did in my patch at www.brimson.com/downloads/ti_usb_multitech-1.1.tgz
is to use request_firmware for new devices, and, if the firmware files are
present, for the existing 3410 and 5052 devices. If the firmware files are
not present for 3410 and 5052, then it uses the compiled in firmware.
I will submit that patch, split into the request_firmware part and
the support for new devices.
* The whitespace, 80 cols, dbg cleanup is great--maybe put that in a separate
patch.
* I would not remove the comments about the hotplug script until we
can use the 2.6.19 usb_driver_set_configuration function.
* - status = -ENODEV;
+ status = 0xFAC; /* greater than zero -- device is going down
*/
- status = -ENODEV;
+ status = 0x0FF;
Why 0xFAC and 0x0FF? I will have to investigate and test this. I think
we want negative values.
* + dev_info(&dev->dev, "%s - Choose configuration #2, please.\n",
+ ti_usb_driver.name);
+
This is what the hotplug script does automatically. Drop this info message.
* Using smaller buffers in download_firmware sounds like a good idea.
I will look at that next week--no time tonight.
* +#define TI_3410_EZ430_ID 0xF430 /* TI ez430 development tool
*/
Where do you use this?
Thanks,
-- Al
Quoting Oleg Verych <olecom@gmail.com>:
> On 12/14/06, Greg KH <greg@kroah.com> wrote:
> > On Thu, Dec 14, 2006 at 11:10:46PM +0200, Oleg Verych wrote:
> > > Hallo. Due to very big distance to my usual work stand, please accept
> this.
> >
> > Hm, I don't think this driver is "orphaned". Please work with Al to get
> > this accepted through him, I'll have to wait for his ACK on it.
> >
> After my ID patch, i don't think so. After not having sem->mutex, i
> don't think so.
> After some other issues, i don't think so. Maybe that just was summer.
>
> Mister Al, please review my patch (here
> <http://article.gmane.org/gmane.linux.usb.devel/49174>).
> All comments are welcome. I hope this will be nice little good for Debian...
>
> --
> -o--=O`C
> #oo'L O
> <___=E M
>
Reply to: