Bug#381677: closed by maximilian attems <maks@sternwelten.at>

[maximilian attems <maks@sternwelten.at>]

reopen 381677
found 381677 0.85a
stop

On Sun, Nov 05, 2006 at 03:17:07PM +0100, Lionel Elie Mamane wrote:
> On Wed, Sep 27, 2006 at 09:34:17AM -0700, Debian Bug Tracking System wrote:
> > From: maximilian attems <maks@sternwelten.at>
> > To: 381677-close@bugs.debian.org
> > Subject: Bug#381677: fixed in initramfs-tools 0.81
> 
> >    * mkinitramfs: Allow an hook script to set an paranoid umask, considered
> >      useful for shipping gpg keys inside of initramfs. Thanks Max Vozeler
> >      <max@nusquama.org> and Lionel Elie Mamane <lionel@mamane.lu> for the
> >      patch. (closes: 381677)
> 
> Thanks, but you forgot my post-patch comment:
> 
> The added code block needs to be _after_ the
> 
>   if [ -z "${outfile}" ]; then
>   	usage
>   fi
> 
> where "the added code block" refers to
> 
>  touch $outfile
>  outfile="$(readlink -f "$outfile")"
> 
> I suggest you swap these two code blocks, so that starting mkinitramfs
> without an output file gives the usage information and not:
> 
>  touch: missing file operand
>  Try `touch --help' for more information.
> 
> Also
>  touch "${outfile}"
> is better style (works with filenames containing spaces).
> 
> -- 
> Lionel

thanks for check,
fixed in repo for 0.85b.

-- 
maks