Re: [kernel] r7596 - in people/jurij/ipw3945-daemon: . debian
On Wed, Oct 11, 2006 at 06:12:22PM +0200, Bastian Blank wrote:
> On Wed, Oct 11, 2006 at 08:31:47AM -0700, Jurij Smakov wrote:
> > > > +DAEMON_PID='/var/run/ipw3945d.pid'
> > > It makes never sense to modify the pid file location.
> > It's a matter of taste, I guess. I only added that variable because
> > pid file is mentioned more than once in the script. Once the variable
> > is there, I don't think there is any harm to let local admin to modify
> > it.
>
> The deamon tries to write that pidfile themself and forgets the third
> parameter of open at least in the version I have. Maybe they fixed that.
Not sure about that, but I just tried to run my script and it fails to
create the pidfile because it cannot write to /var/run as non-root.
This is trivially solvable by creating a subdir in /var/run and
chown'ing it to the daemon's user/group. I'll adjust the postinst and
init script accordingly.
> > Again ${cmd} is not the daemon itself, but the relevant entries in
> > /sys. I have just followed the installation instructions in
> > README file, so if I chown/chmod stuff in /sys and run daemon as
> > this special user, I don't see why it would not work. I will test it
> > tonight.
>
> Hrm, I though I checked that. Thats another occurance of inode without
> setfattr function which provided us the 2.6.17.5 and .6 releases.
I can't really parse that sentence :-), but with the changes I've just
committed the daemon runs fine and works as non-root.
Best regards,
--
Jurij Smakov jurij@wooyd.org
Key: http://www.wooyd.org/pgpkey/ KeyID: C99E03CC
Reply to: