Re: Preparing linux-2.6 2.6.18-1

[Nathanael Nerode <neroden@fastmail.fm>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sven Luther wrote:
> On Mon, Sep 25, 2006 at 05:55:22AM -0400, Nathanael Nerode wrote:
>>> tg3 may follow, if there is
>>> a good enough patch to do it nicely. This may come, either from someone like
>>> you (but the patch has to be upstream-quality, which apparently your patch was
>>> not),
>> Yes, it was upstream-quality.  (Although to be honest the *driver* is
>> pretty ugly stuff.)  There was one bug spotted by Herbert Xu and fixed
>> by him.
> 
> This is not the opinion of others of the kernel team who looked at it.

Name one specific problem with it, or stop slandering it.

Really.  Seriously.  I've never gotten an actual technical criticism,
besides the ones I mentioned before, which are all problems with
firmware loading in general, and not problems with my patch itself.
I'd be happy to fix any actual problems, but I can't fix mythical
problems which nobody is willing to describe.

The code *is* ugly.  It's ugly because the upstream code is ugly --
nearly the whole driver is in a spinlock.  I'm not up to rewriting the
entire driver to increase lock granularity: that requires an extremely
detailed understanding of the hardware and driver.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD4DBQFFIcY0RGZ0aC4lkIIRAngFAJ91LnvcBaFsz4XqvYTkFrWbZXRbHwCXVQXI
1tNQYIBlsz4OFrhL78uP5A==
=Y6s8
-----END PGP SIGNATURE-----