Bug#360065: kernel-source-2.4.27: kernel panic during backups when using lvm snapshots
Package: kernel-source-2.4.27
Version: 2.4.27-10sarge2
Severity: important
Tags: patch
kernel panic (usually during backups) on a 4-way smp machine which uses lvm
snapshots. Included patch is now in 2.4.x mainline, and is as discussed
on the linux-lvm list:
http://www.redhat.com/archives/linux-lvm/2005-March/msg00117.html
The panic has been difficult to reproduce, but the patch from the above
thread does seem to fix.
Patch is against:
kernel-source-2.4.27/drivers/md/lvm-snap.c
--- lvm-snap.c.dist 2006-03-30 12:09:42.000000000 +0100
+++ lvm-snap.c 2006-03-30 12:12:08.000000000 +0100
@@ -119,7 +119,6 @@
unsigned long mask = lv->lv_snapshot_hash_mask;
int chunk_size = lv->lv_chunk_size;
lv_block_exception_t *ret;
- int i = 0;
hash_table =
&hash_table[hashfn(org_dev, org_start, mask, chunk_size)];
@@ -132,15 +131,9 @@
exception = list_entry(next, lv_block_exception_t,
hash);
if (exception->rsector_org == org_start &&
exception->rdev_org == org_dev) {
- if (i) {
- /* fun, isn't it? :) */
- list_del(next);
- list_add(next, hash_table);
- }
ret = exception;
break;
}
- i++;
}
return ret;
}
-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.4.27-3-686-smp
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)
Versions of packages kernel-source-2.4.27 depends on:
ii binutils 2.15-6 The GNU assembler, linker and bina
ii bzip2 1.0.2-7 high-quality block-sorting file co
ii coreutils [fileutils] 5.2.1-2 The GNU core utilities
-- no debconf information
Reply to: