[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#346511: ext3 online resizing doesn't work

* Tore Anderson

>   I can't get online resizing of ext3 to work.

  After some more debugging it seems that the "resize" option isn't
 correctly parsed by fs/ext3/super.c.  Patch attached.  However, I'm not
 too sure if it is correct, right now my mount process is hanging in
 blocking I/O state, and there's almost no disk activity.  I started it
 two and a half hour ago...  The only thing the kernel had to say about
 it was:

    EXT3-fs warning (device dm-3): ext3_group_extend: will only finish group (4194305 blocks, 1 new)

  I suspect ext2online(8) is the only supported way of doing online
 resizing, and that the resize= mount option is intentionally broken
 because of that.  Perhaps it's a relic from the early days of the code
 in question...  But I don't know.

Tore Anderson
Fix parsing of the resize=nblocks ext3 (re)mount option.

Signed-off-by: Tore Anderson <tore@fud.no>

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 4e67306..1eb16f5 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -681,8 +681,8 @@ static match_table_t tokens = {
 	{Opt_quota, "quota"},
 	{Opt_usrquota, "usrquota"},
 	{Opt_barrier, "barrier=%u"},
+	{Opt_resize, "resize=%u"},
 	{Opt_err, NULL},
-	{Opt_resize, "resize"},
 static unsigned long get_sb_block(void **data)

Reply to: