Bug#336928: marked as done (yaird should use /etc/mtab or the mount output to determine the filesystem, instead of fstab)
Your message dated Thu, 10 Nov 2005 22:08:40 +0100
with message-id <20051110220840.0a796a9d.dr@jones.dk>
and subject line Bug#336928: yaird should use /etc/mtab or the mount output to determine the filesystem, instead of fstab
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 1 Nov 2005 20:53:02 +0000
>From luther@debian.org Tue Nov 01 12:53:02 2005
Return-path: <luther@debian.org>
Received: from smtp3.wanadoo.fr [193.252.22.28]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EX37u-0002B3-00; Tue, 01 Nov 2005 12:53:02 -0800
Received: from me-wanadoo.net (localhost [127.0.0.1])
by mwinf0309.wanadoo.fr (SMTP Server) with ESMTP id C13B31C007FE
for <submit@bugs.debian.org>; Tue, 1 Nov 2005 21:52:31 +0100 (CET)
Received: from pegasos (AStrasbourg-251-1-14-84.w82-126.abo.wanadoo.fr [82.126.204.84])
by mwinf0309.wanadoo.fr (SMTP Server) with ESMTP id A26011C007DD
for <submit@bugs.debian.org>; Tue, 1 Nov 2005 21:52:31 +0100 (CET)
X-ME-UUID: 20051101205231665.A26011C007DD@mwinf0309.wanadoo.fr
Received: from sven by pegasos with local (Exim 4.50)
id 1EX355-0007EI-QU
for submit@bugs.debian.org; Tue, 01 Nov 2005 21:50:07 +0100
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Sven Luther <luther@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: yaird should use /etc/mtab or the mount output to determine the filesystem,
instead of fstab
X-Mailer: reportbug 3.8
Date: Tue, 01 Nov 2005 21:50:02 +0100
Message-Id: <E1EX355-0007EI-QU@pegasos>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-7.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
RCVD_IN_SORBS autolearn=no version=2.60-bugs.debian.org_2005_01_02
Package: yaird
Severity: normal
hi Erik, hi Jonas, ...
I think it would be better for yaird to use /etc/mtab instead of /etc/fstab to
parse for the root mount point, in effect, this one is guaranteed to be always
full fielded, and not have any of the problems related to strangely filled
user entries in the /etc/fstab.
Here is an example of my own / line :
/dev/hda12 / ext3 rw,noatime,errors=remount-ro,commit=600 0 0
which is equivalent to the output of the mount command :
/dev/hda12 on / type ext3 (rw,noatime,errors=remount-ro,commit=600)
A very tentative untried patch may be :
--- perl/FsTab.pm (revision 4702)
+++ perl/FsTab.pm (working copy)
@@ -34,7 +34,7 @@
return;
}
$fsTab = [];
- my $name = Conf::get('fstab');
+ my $name = Conf::get('mtab');
if (! open (IN, "<", "$name")) {
Base::fatal ("can't read $name");
}
Altough something more advanced where it searches for mtab and falls back to
fstab if no mtab exists may be more adequate.
Notice that i did remember some code in debian-installer doing exactly this,
but i don't remember where it was.
Friendly,
Sven Luther
-- System Information:
Debian Release: 3.1
Architecture: powerpc (ppc)
Kernel: Linux 2.6.12-1-powerpc
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
---------------------------------------
Received: (at 336928-done) by bugs.debian.org; 10 Nov 2005 21:09:47 +0000
>From dr@jones.dk Thu Nov 10 13:09:46 2005
Return-path: <dr@jones.dk>
Received: from 0x3ef3a55b.virnxx2.adsl-dhcp.tele.dk ([62.243.165.91] helo=xayide.jones.dk)
by spohr.debian.org with esmtp (Exim 4.50)
id 1EaJeD-0006aP-4H; Thu, 10 Nov 2005 13:07:53 -0800
Received: from localhost (localhost [127.0.0.1])
by xayide.jones.dk (Postfix) with ESMTP id A984011D16C;
Thu, 10 Nov 2005 22:07:53 +0100 (CET)
Received: from xayide.jones.dk ([127.0.0.1])
by localhost (xayide.jones.dk [127.0.0.1]) (amavisd-new, port 10024)
with SMTP id 07043-03; Thu, 10 Nov 2005 22:07:48 +0100 (CET)
Received: from auryn.jones.dk (unknown [192.168.102.231])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by xayide.jones.dk (Postfix) with ESMTP id 2341911B96E;
Thu, 10 Nov 2005 22:07:48 +0100 (CET)
Date: Thu, 10 Nov 2005 22:08:40 +0100
From: Jonas Smedegaard <dr@jones.dk>
To: Frans Pop <aragorn@tiscali.nl>, 336928-done@bugs.debian.org
Cc: 336928@bugs.debian.org
Subject: Re: Bug#336928: yaird should use /etc/mtab or the mount output to
determine the filesystem, instead of fstab
Message-Id: <20051110220840.0a796a9d.dr@jones.dk>
In-Reply-To: <200511022320.24356.aragorn@tiscali.nl>
References: <E1EX355-0007EI-QU@pegasos>
<200511012330.22969.aragorn@tiscali.nl>
<20051102045320.GB4743@localhost.localdomain>
<200511022320.24356.aragorn@tiscali.nl>
Organization: Spiff ApS
X-Mailer: Sylpheed version 2.0.1 (GTK+ 2.6.10; powerpc-unknown-linux-gnu)
X-Face: yvw#o~hz'%$;u|iUBohl)T/ow@lBXi/j&/v4H;'#{E\]pJHQsA0!FKs"='cNj!x=\]NiEsi
PWi#:wS|bY F]0)w+?QXNQi={<6HVU5(98,?_#=d!$YOQ"9Vc%Ax-!?lWZUMj7y}m
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at jones.dk
Delivered-To: 336928-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, 2 Nov 2005 23:20:23 +0100
Frans Pop <aragorn@tiscali.nl> wrote:
> > Anyway, Erik fixed the /etc/fstab probing code so this is moot.
>=20
> So, should this bug be closed?
Well, noone else complaining, soyes: I pull the plug on this one...!
- Jonas
- --=20
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
- Enden er n=E6r: http://www.shibumi.org/eoti.htm
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDc7bYn7DbMsAkQLgRAtRiAJ9xFvI4ERCIgZ7E/L0atGHLl+rUrQCgn9/N
okkroFc3MqEW0rRNorbHiRU=3D
=3Dq1U2
-----END PGP SIGNATURE-----
Reply to: