[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#337168: (no subject)



Subject: fails to parse "LABEL=/" correctly
Package: yaird
Version: 0.0.11-10
Severity: normal
Tags: patch

Hi,

        yaird gives an error when it parses my fstab, saying that label ()
wasn't found. My fstab contains the lines
LABEL=/         /               ext3    defaults,errors=remount-ro 0       1
LABEL=/boot     /boot           ext3    defaults        0       2
but yaird thinks the root partition label has an extra trailing slash,
and removes it, leaving an empty label.

A quick and dirty patch is attached.

Greetings,
Michael.

--- FsTab.pm.old        2005-10-30 07:04:57.000000000 -0500
+++ FsTab.pm    2005-11-02 18:43:22.000000000 -0500
@@ -62,9 +62,14 @@
                #
                # Canon makes sure that mountpoint /usr is same as /usr/.
                # For UUID= devices, it should be harmless.
+               # But it isn't for LABEL= devices (ms)
                #
+               my $dev = unmangle($fields[0]);
+               if ($dev !~ m/^(LABEL|UUID)=/) {
+                       $dev = Base::canon ($dev);
+               }
                my $descr = FsEntry->new(
-                       dev => Base::canon (unmangle($fields[0])),
+                       dev => $dev,
                        mnt => Base::canon (unmangle($fields[1])),
                        type => unmangle($fields[2]),
                        opts => $opts,


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages yaird depends on:
ii  cpio                         2.6-9       GNU cpio -- a program to
manage ar
ii  dash                         0.5.2-8     The Debian Almquist Shell
ii  libc6                        2.3.5-7     GNU C Library: Shared
libraries an
ii  libhtml-template-perl        2.6-2       HTML::Template : A module
for usin
ii  libparse-recdescent-perl     1.94.free-1 Generates recursive-descent
parser
ii  perl                         5.8.7-7     Larry Wall's Practical
Extraction

yaird recommends no packages.

-- no debconf information




Reply to: